EdColeman

Results 143 comments of EdColeman

Sorry - this comment applies to #2812 Looking at the method in 'Key' the method that performs the equality check on a byte array `private static boolean isEqual(byte[] a1, byte[]...

The current tests cover what would have gone in those stubs - as well as what is now covered by ITs

See[ #2829 ](https://github.com/apache/accumulo/pull/2829) for a discussion on changing the name of prop_debug to something that reflects what is stored, vs how it can be used.

There should not be an issue with backward compatibility and previously stored data. When performing an upgrade there should not be any outstanding FATE transactions - this includes transaction that...

To clarify why I think the rename is important to improve code readability and being able to understand FATE transactions. The name prop_debug and its usage does not convey what...

Currently seeking comments on approach - solution is complete if there are no objections - still should add tests (tested manually using uno)

`I think I would benefit from a basic explanation of what this PR is trying to do` The cache implementation provides multiple ways to refresh and expire entries. - refreshAfterWrite()...

I have addressed @ctubbsii comments (one's left unresolved are to allow him to concur) - but this is ready for general review.

This addresses all current PR comments. Because this is current with main, the full IT tests are likely to fail (see #2837) I think those failures are outside of this...

I believe that I have addressed the issues as much as can be done without a total refactor. I think it represents an incremental improvement of the current code and...