open-vsx.org icon indicating copy to clipboard operation
open-vsx.org copied to clipboard

Problem with two different publications of the same extension

Open alesanchezr opened this issue 2 years ago • 7 comments

Hello! I have a problem with two versions of the same extension that are published on the openvsx marketplace: two versions of learnpack

I would like to keep only learn-pack and remove learnpack

alesanchezr avatar Aug 27 '22 00:08 alesanchezr

This is puzzling. When I examine the learnpack namespace, I see this: image

But when I attempt to access the LearnPack extension in that namespace from the admin panel, I see this: image

Same thing happens with learn-pack. @amvanbaren @eclipsewebmaster, am I missing something?

kineticsquid avatar Aug 29 '22 13:08 kineticsquid

@kineticsquid The extension name is learnpack-vscode. It can be found here: https://open-vsx.org/api/learnpack

The webui shows the extension display name. Maybe we can add a tooltip or code block to show the extension name? Or allow searching by extension display name in the admin panel?

amvanbaren avatar Aug 29 '22 19:08 amvanbaren

@amvanbaren thanks for the pointer. What you suggest could be helpful, but not necessary right now. I can use a url of the form https://open-vsx.org/api/{namespace} to get the names of the extensions.

kineticsquid avatar Aug 30 '22 15:08 kineticsquid

Doh, I just realized it's also available on the extension page: Screen Shot 2022-08-30 at 11 55 30 AM

kineticsquid avatar Aug 30 '22 15:08 kineticsquid

@alesanchezr, I just removed 0.0.1 - 0.0.7 of learnpack.learnpack-vscode.

kineticsquid avatar Aug 30 '22 15:08 kineticsquid

@amvanbaren Is there a way to remove a namespace? Assuming there is, @alesanchezr do you want me to remove the learnpack namespace?

kineticsquid avatar Aug 30 '22 16:08 kineticsquid

@amvanbaren ^^^^

kineticsquid avatar Oct 17 '22 14:10 kineticsquid

@amvanbaren Thoughts on this?

kineticsquid avatar Oct 24 '22 14:10 kineticsquid

There's a OrphanNamespaceMigration. It cleans up namespaces without extensions. https://github.com/eclipse/openvsx/blob/8bf1d23af572aebe2321f304ea605ceb6b8f0923/server/src/main/java/org/eclipse/openvsx/migration/OrphanNamespaceMigration.java#L44-L47

amvanbaren avatar Oct 24 '22 14:10 amvanbaren

Does it run automatically? learnpack namespace is there with no extensions.

kineticsquid avatar Oct 24 '22 15:10 kineticsquid

It runs on server startup. An orphaned namespace is a namespace without any members. https://github.com/eclipse/openvsx/blob/8bf1d23af572aebe2321f304ea605ceb6b8f0923/server/src/main/java/org/eclipse/openvsx/repositories/NamespaceRepository.java#L25-L26

I don't know 100% if this is possible, but you might be able to delete all namespace members in the admin panel.

amvanbaren avatar Oct 24 '22 16:10 amvanbaren

I did, I just deleted the two members listed. Now there are none.

kineticsquid avatar Oct 24 '22 17:10 kineticsquid

Ok, I have a small fix for production: https://github.com/EclipseFdn/open-vsx.org/pull/1343 When approved, I can deploy it to production. The new deployment should then delete the learnpack namespace after the server started.

amvanbaren avatar Oct 24 '22 17:10 amvanbaren

learnpack has been deleted: https://open-vsx.org/api/learnpack

amvanbaren avatar Oct 24 '22 19:10 amvanbaren

Thanks @amvanbaren!

kineticsquid avatar Oct 24 '22 23:10 kineticsquid