PerWorldInventory icon indicating copy to clipboard operation
PerWorldInventory copied to clipboard

Published 20 hours ago • verified publisher icon EbonJaeger

OutOfMemoryError

Open PikaMug opened this issue 8 years ago • 10 comments

Hello! Large server wishing to switch to PerWorldInventory...

Within seconds of running "/pwi convert multiverse" we get this error spammed before the server closes:

http://pastebin.com/f47kMwad

[21:15:58] [Server thread/INFO]: This server is running CraftBukkit version git-Spigot-4741400-a1d3777 (MC: 1.11.2) (Implementing API version 1.11.2-R0.1-SNAPSHOT) [21:16:02] [Server thread/INFO]: [Multiverse-Inventories] Loading Multiverse-Inventories v2.5-b408

There are 12,010 players to convert, so I'm not surprised this happened. Hope a solution can be found soon as this is clearly the best upgrade from Multiverse!

PikaMug avatar Feb 05 '17 02:02 PikaMug

Well then. I think this is a sign that i need to implement only converting batches at a time....

EbonJaeger avatar Feb 05 '17 02:02 EbonJaeger

@Gnat008 You're a legend! Can a development version be downloaded or should I build this myself? Thanks! :)

EDIT: Just saw your "In Progress" label so I'll wait til it's done.

PikaMug avatar Feb 06 '17 19:02 PikaMug

I can make one later, but if you can build it yourself, you may as well do that. Might want to wait for the next commit though, I'm adding some testing that found a significant bug. heh.

EbonJaeger avatar Feb 06 '17 19:02 EbonJaeger

@FlyingPikachu The branch should be ready for actual testing now, if you have a testing server to do it on.

EbonJaeger avatar Feb 06 '17 19:02 EbonJaeger

@Gnat008 Seeing the following error after cloning the branch:

perworld

PikaMug avatar Feb 07 '17 02:02 PikaMug

That file hasn't changed, and it doesn't do that for me.

EbonJaeger avatar Feb 07 '17 02:02 EbonJaeger

@FlyingPikachu For the moment you can use this; there have been no changes since the last commit: https://drive.google.com/file/d/0B7hS84xeTkpsLThpTmI4bHdvMnc/view?usp=sharing

Maybe @ljacqu could shed light on that one.

EbonJaeger avatar Feb 07 '17 03:02 EbonJaeger

Looks like an Eclipse compiler issue. The method is <T> getProperty(Property<T>) and the test setup uses Mockito's <M> Matchers.any(Class<M>)1 where Class<M> is Property, hence M = Property without any generics.

1: Using another letter for clarity.

The tl;dr is I will install Eclipse and check this out tonight ;)

ljacqu avatar Feb 07 '17 06:02 ljacqu

I'm not going to be able to check this out in Eclipse tonight, the quick fix for this is to just delete that class since it's a test class.

ljacqu avatar Feb 07 '17 19:02 ljacqu

@ljacqu Interesting, thanks!

@Gnat008 Encountered some errors. Here's the console output for the build you linked:

http://pastebin.com/cwGcnqf2

PikaMug avatar Feb 07 '17 23:02 PikaMug