PerWorldInventory icon indicating copy to clipboard operation
PerWorldInventory copied to clipboard

[DO NOT MERGE] New mysql impl

Open EbonJaeger opened this issue 8 years ago • 7 comments

PR to track changes to the new MySQL (and likely SQLite) implementation.

EbonJaeger avatar Jan 24 '17 22:01 EbonJaeger

Coverage Status

Coverage decreased (-2.04%) to 27.665% when pulling d11456164dca984347abed058f58dbcd44bd2a42 on new-mysql-impl into 23a5ae58b7c296061e08bedd79dfa0b124fc3ff7 on master.

coveralls avatar Jan 24 '17 22:01 coveralls

Coverage Status

Coverage decreased (-3.5%) to 26.253% when pulling 0945f6dadce5c365583ee85a20d9755bb8753f57 on new-mysql-impl into cd280290387461eb4b5e363f65cf38005f08fd1b on master.

coveralls avatar Jan 25 '17 01:01 coveralls

Coverage Status

Coverage decreased (-3.6%) to 26.167% when pulling b3efbe5a641cfcd072dc348d9ab3bd84ea2481bb on new-mysql-impl into cd280290387461eb4b5e363f65cf38005f08fd1b on master.

coveralls avatar Jan 25 '17 16:01 coveralls

Coverage Status

Coverage decreased (-4.4%) to 25.395% when pulling 894e6379ab3e25ffa9da59c8d474f1e443bc8a0a on new-mysql-impl into cd280290387461eb4b5e363f65cf38005f08fd1b on master.

coveralls avatar Jan 25 '17 17:01 coveralls

Coverage Status

Coverage decreased (-4.5%) to 25.289% when pulling 2f498b7213f40b0982020a6bf17a8bcd1eba382c on new-mysql-impl into cd280290387461eb4b5e363f65cf38005f08fd1b on master.

coveralls avatar Jan 28 '17 22:01 coveralls

Coverage Status

Coverage decreased (-5.8%) to 23.968% when pulling db32d6a77798d5fe3b3fb8a97b0c00eb3bf40aef on new-mysql-impl into cd280290387461eb4b5e363f65cf38005f08fd1b on master.

coveralls avatar Jan 29 '17 00:01 coveralls

Notes for tomorrow:

  • Make getFromDatabase() methods have a return type
    • Need to find a way to not need two (three when SQLite becomes a thing) different code paths
      • Maybe in the getFromDatabase() method, make a Map<String, Object>, populate it, and return it?
  • DataSource implementations should only deal with I/O; process classes (maybe new task classes?) should deal with logic and applying stats, inventories, etc. to players
  • Let the code calling these I/O methods worry about scheduling; DataSource implementations don't need to

EbonJaeger avatar Jan 29 '17 04:01 EbonJaeger