liblcf icon indicating copy to clipboard operation
liblcf copied to clipboard

rpg::Actor Add unknown 3A and 40 chunks found in DynRPG

Open mateofio opened this issue 5 years ago • 3 comments

mateofio avatar Oct 15 '20 01:10 mateofio

btw while I was investigating the dungeon generator I'm pretty sure that I also found some unknown chunks in the code that reads the map properties:

In function 487A34 the values: 2B, 2C, 2D, 2E, 2F.

So I'm not really sure if we really want to document them all. There seem to be alot??

Ghabry avatar Mar 16 '21 19:03 Ghabry

I'm on the fence about this one.

If they are truly not used at all by RPG_RT, then there isn't much value in adding memory for them to our structures. That includes the chunks in this PR.

That being said, we do want to be sure the chunk IDs don't get reused for some custom feature later.

mateofio avatar Mar 16 '21 19:03 mateofio

Not reusing the chunks is a valid concern. Lets keep this open longer, bet it is not hard to find even more...

fdela suggested they could be editor-only chunks (temporary data that is not saved). But this investigating the editor which is some work...

Ghabry avatar Mar 16 '21 19:03 Ghabry