liblcf icon indicating copy to clipboard operation
liblcf copied to clipboard

Better abstraction for "Fixup" and "Setup"

Open mateofio opened this issue 5 years ago • 0 comments

There are a lot of cases where lcf save data has a sentinel value, which means to defer to the database.

For example if SaveMapInfo::chipset_id == -1 that means use the chipset from the map etc..

There are a few fields which do this logic directly in player when you request the field, while others have a FixUp() function in liblcf which is supposed to be called.

I'm not a huge fan of these fixup functions, maybe there is a better abstraction for this behavior? Also we should unify how we handle this between lcf and player

  • [ ] Actor
  • [x] SaveActor
  • [x] SaveSettings
  • [x] SaveInventory
  • [x] SaveMapInfo
  • [ ] Parameters

mateofio avatar May 26 '20 03:05 mateofio