buildscripts icon indicating copy to clipboard operation
buildscripts copied to clipboard

Fluidsynth: Drop glib patch when 2.5 is released

Open Ghabry opened this issue 7 months ago • 2 comments

Next fluidsynth version adds an abstraction layer that is either for embedded -Dosal=embedded of for C++11 -Dosal=cpp11 (https://github.com/FluidSynth/fluidsynth/pull/1570).

cpp11 is useful for our desktop/mobile platforms and embedded for homebrew (because thread and mutex implementation is broken).


Currently embedded lacks big endian support but I'll submit a patch upstream to get this in.


Required changes shared/patched.sh manually specifiy all the OFF options:

FLUIDSYNTH_ARGS="-DLIB_SUFFIX='' -Denable-alsa=OFF -Denable-aufile=OFF -Denable-dbus=OFF -Denable-ipv6=OFF -Denable-jack=OFF -Denable-ladspa=OFF -Denable-libinstpatch=OFF -Denable-libsndfile=OFF -Denable-midishare=OFF -Denable-network=OFF -Denable-oss=OFF -Denable-dsound=OFF -Denable-wasapi=OFF -Denable-waveout=OFF -Denable-winmidi=OFF -Denable-sdl3=OFF -Denable-pulseaudio=OFF -Denable-pipewire=OFF -Denable-readline=OFF -Denable-threads=OFF -Denable-openmp=OFF -Denable-unicode=OFF"

(Generated via prompt "Here are CMake options, give me a command line that sets all ON options with -DOPTION=OFF to off" + manual check for correctness ;))

  1. Add -Dosal=PLATFORM (PLATFORM = embedded or cpp11) depending on the system.

Edit: patch submitted https://github.com/FluidSynth/fluidsynth/pull/1575

Ghabry avatar May 24 '25 10:05 Ghabry

2.4.7 is out but it looks to me like this feature is actually not expecting to get into a tag until 2.5? Have I missed something?

Splendide-Imaginarius avatar Aug 27 '25 08:08 Splendide-Imaginarius

No that was my fault. I assumed they directly tag releases from the master branch but they only pick bugfixes for 2.4.x... Lets wait for 2.5 then.

Ghabry avatar Sep 22 '25 07:09 Ghabry