EasyRPG
Rewrite ControlGlobalSave
Main difference is the logic when opening the save. Also moved it to ManiacPatch file to reduce complexity in the interpreter code.
Header cleanup (was necessary because of weird compile errors due to a Game_String include while moving code around)
Fix #3069
@Mimigris please test this. Should be at least closer than before xD
Sorry for answering a bit late on this, just started my testing.
From what I can see, the Save.lgs file is not able to be created at the moment using the build of this pull request, only updated, meaning that storing data in a Save.lgs file is impossible unless said file already existed, so this would probably need to be fixed before doing bigger testings due to being at the heart of the command.
Yeah my bad, the flag that tracked whether the global save is "opened" what only set when the file exists... Is fixed now
Noticed a crash with the current setup. I have the Player set outside of a game folder, and I use it to open a folder containing the game (game in question being the EasyRPG TestGame made for Maniac). If I use the command Open Global Save in the command, then exit it, then make the program close by exiting the game browser, the Player will crash instead of closing as intended.
ResetGameObjects was not called when doing it as you described.
I added this call now to Continue from the game browser. No idea why this wasn't used before, seems to work fine (likely some other bugfix before).
Outside of the last point mentioned in #3069 , which has been explained in chat why it has not been adressed (tied to the path cache + not something that would be noticeable while playing normally), everything seems good from what I see 👍