Player icon indicating copy to clipboard operation
Player copied to clipboard

Maniac Patch : Fix String Vars with ShowPicture

Open ToolMan2k opened this issue 1 year ago • 4 comments

Added the following:

  • Check if we're using a string variable with com.parameters[17]
  • Set the name parameter to the String Variable

Fixed the following:

  • When using a String Var with ShowPicture, it no longers crash the game with picture ID -1

Before: 😿 EasyRPG-Failure

After: 😺 EasyRPG-Winners

ToolMan2k avatar Jan 07 '24 02:01 ToolMan2k

Thanks!

String Vars is a very recent implementation, I wonder if more commands can break when using it.

jetrotal avatar Jan 07 '24 02:01 jetrotal

Well as you say that. I managed to misplace a "]" character. Fixed it, now it works!

ToolMan2k avatar Jan 07 '24 03:01 ToolMan2k

@ToolMan2k thx again!

One suggestion: image

Squashing commits like "fixing typos" or "remove debug/comments" always help shortening and maintaning the list of commits

jetrotal avatar Jan 07 '24 03:01 jetrotal

Squashing commits like "fixing typos" or "remove debug/comments" always help shortening and maintaning the list of commits

Will do!

ToolMan2k avatar Jan 07 '24 14:01 ToolMan2k

I fixed a bug and moved the commits into you other PR. thanks!

Ghabry avatar Mar 11 '24 19:03 Ghabry