Player icon indicating copy to clipboard operation
Player copied to clipboard

Picture flash doesn't work on lower layers

Open mateofio opened this issue 5 years ago • 1 comments

Because of the way we blit flash effects to the screen, pictures on layers below weather misbehave.

player_flash

The left are all layers unaffected by flash, the right affected by flash.

All the clouds are supposed to look like the bottom row.

mateofio avatar Dec 07 '19 20:12 mateofio

I thinking for this one. Maybe the optimal solution is:

  1. In z order render all drawables that are affected by flash, without the effect, until the first one that isn't.
  2. Render flash on the entire display
  3. Now render remaining drawables in Z order, flashing each one individually if it's affected.

For most games which don't use lower layer pictures unaffected by flash, this would maintain the optimization we currently have.

The same can be done for tone.

mateofio avatar Dec 12 '19 17:12 mateofio