Player icon indicating copy to clipboard operation
Player copied to clipboard

Better interpreter debugging support

Open mateofio opened this issue 6 years ago • 1 comments

Add better debugging support to the interpreter.

  • [ ] Event Type: None, Map, Common, Battle
  • [ ] Map Event Id, Page Id
  • [ ] Common Event Id
  • [ ] Battle Event Page
  • [ ] Standard logging functions which log the above info the same way for all interpreter logs
  • [ ] Standard interpreter stack trace to debug game code.

mateofio avatar Jul 31 '19 00:07 mateofio

  • [x] Event Type: None, Map, Common, Battle
    • Included in proposed refactor PR #3349 by making use of maniac_event_info
  • [x] Map Event Id, Page Id
    • Already included with PR #3219, by supporting the Maniac fields maniac_event_id & maniac_event_page_id (Set regardless if patch is enabled or not)
  • [x] Common Event Id
    • Included in proposed refactor PR #3349 (Also saved in maniac_event_id")
  • [ ] Battle Event Page
    • Not yet possible, but we could also include this by reusing maniac_event_page_id and differentiating event types with maniac_event_info
  • [ ] Standard logging functions which log the above info the same way for all interpreter logs
  • [ ] Standard interpreter stack trace to debug game code.

Some callstack info has been available since merging PR #3219, though there is much room for improvement here & the new PR makes some small changes by including the newly available info. I would be open to refactor this format to make it more useful & maybe even add a new command code for printing the current callstack.

Callstack logging is also mentioned in Issue #786.

florianessl avatar Mar 22 '25 17:03 florianessl