EasyNetQ.Management.Client icon indicating copy to clipboard operation
EasyNetQ.Management.Client copied to clipboard

More usages of JsonExtensionData; ParameterShovelValue

Open inikulshin opened this issue 1 year ago • 8 comments

https://github.com/EasyNetQ/EasyNetQ.Management.Client/issues/269 https://github.com/EasyNetQ/EasyNetQ.Management.Client/issues/257

inikulshin avatar Dec 21 '23 12:12 inikulshin

@Pliner I see that shorter PRs are completed faster. :) Do you want me to split this one too?

inikulshin avatar Dec 24 '23 11:12 inikulshin

Hey @inikulshin,

Sorry for the delay! I just need to find some time to review it, will try to do that today.

Pliner avatar Dec 24 '23 12:12 Pliner

Hey @inikulshin,

Sorry for the delay! I just need to find some time to review it, will try to do that today.

I think that splitting this PR to smaller unrelated PRs is good idea. I already created some and will create more.

So, this one should be abandoned. Update: converted to draft.

inikulshin avatar Dec 24 '23 12:12 inikulshin

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?

Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?

if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

zidad avatar Jan 04 '24 12:01 zidad

@zidad the only things left are:

  1. Add missing GetQueuesWithoutStatsAsync variants (should be 4 like for GetQueuesAsync: [all | vhost] x [all | by page]
  2. Rename for #257

inikulshin avatar Jan 05 '24 10:01 inikulshin

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned?

Other question since you're contributing the most at the moment, are you interested in becoming a core contributor?

if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

inikulshin avatar Jan 14 '24 13:01 inikulshin

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned? Other question since you're contributing the most at the moment, are you interested in becoming a core contributor? if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

Isn't it open to join for you?

zidad avatar Jan 15 '24 10:01 zidad

Hi @inikulshin, is there anything left in this PR that isn't merged or can it be closed/abandoned? Other question since you're contributing the most at the moment, are you interested in becoming a core contributor? if you're interested let's discuss it in our slack channel please: https://easynetq.slack.com/

Do you need my email to invite me?

https://join.slack.com/t/easynetq/shared_invite/zt-2ar9kqe4j-AOHgfmRa0fLHJ~_I1TMzLg

zidad avatar Jan 17 '24 11:01 zidad