EasyNetQ.Management.Client icon indicating copy to clipboard operation
EasyNetQ.Management.Client copied to clipboard

Feature/add ha sync batch size

Open ArgTang opened this issue 5 years ago • 6 comments

#125

  • Adding property to PolicyDefinition to support setting sync batch size
  • VS changed indenting based on .editorconfig
  • Fix Docker connection, for running tests https://github.com/microsoft/Docker.DotNet/issues/397#issuecomment-500186485

ArgTang avatar Aug 30 '19 20:08 ArgTang

@zidad I am not too familiar with travis, do you have an idea for what could be wrong?

ArgTang avatar Aug 30 '19 20:08 ArgTang

I'm not sure if we should keep the travis build in there. Seems a bit overkill now with .NET core. @luigiberrettini knows about this? Can we just get rid of the travis build or did the changes in the PR break the build?

zidad avatar Sep 02 '19 13:09 zidad

@ArgTang what was the need for the changes in the docker configuration, before it seemed to run fine on travis, can you undo that and see if it works?

zidad avatar Sep 02 '19 13:09 zidad

@zidad i can try when i get home. The reason for the change was that i was not able to run any of the tests on my local machine.

ArgTang avatar Sep 02 '19 13:09 ArgTang

Having AppVeyor and Travis CI allows to build code and run tests against Docker containers on both Windows and Linux. It would be nice to also do so on OS X but Docker support for Travis CI matrix builds was missing at the moment I created the scripts (I didn't check if this is still the case).

luigiberrettini avatar Sep 02 '19 14:09 luigiberrettini

@zidad reverted test running changes.

ArgTang avatar Sep 08 '19 17:09 ArgTang

Fixed in #172

Pliner avatar Dec 11 '22 23:12 Pliner