EasyDutch icon indicating copy to clipboard operation
EasyDutch copied to clipboard

ALL tweakers.net issues

Open TjeuKayim opened this issue 2 years ago • 29 comments

Important note by EasyDutch authors:

uBlock Origin uses four links to update our list in their add-on/extension.
The contentURL is instantly updated after a commit, and the same applies for the first cdnURL. The other two cdnURLs are updated less.
If there is a fix you need immediately, I can update mannualy two of the three CDN's: the first cdnURL and the second jsDelivr cdnURL by going to https://www.jsdelivr.com/tools/purge.


Prerequisites / Vereisten

Describe the issue

Pages like https://tweakers.net/reviews/10768/gelikte-code-met-pyscaffold-python-projecten-ontwikkelen-als-een-pro.html are asking users to disable their adblocker.

Notes

After debugging with dev tools, I found that adding tweakers.net##+js(set, window.BannerManager, undefined) to 'My filters' in uBlock Origin bypasses the anti adblock. Though I have no experience writing these rules.

Screenshot(s)

image

TjeuKayim avatar Jan 15 '23 19:01 TjeuKayim

Sorry, I selected the wrong category, this should not have been labelled 'documentation'

TjeuKayim avatar Jan 15 '23 19:01 TjeuKayim

Maybe better fix:

tweakers.net##+js(aeld, bannerLoadEvent, adblock) ?

nicolaasjan avatar Jan 16 '23 08:01 nicolaasjan

De fix werkt niet meer zo te zien.

https://tweakers.net/reviews/10866/is-matter-de-toekomst-van-smarthome-alles-wat-je-moet-weten-over-deze-standaard.html

Untitled

TheQuickFox avatar Feb 16 '23 02:02 TheQuickFox

Indeed. But there are two options now.

  1. unblock aa.tweakers.net, which is not what we want as they track you via that domain
  2. block the notice, but then you can't read the whole article.

edit: We opened an issue at uAssets to help us solve this.

JohnyP36 avatar Feb 16 '23 15:02 JohnyP36

The issue seems to be with this script: https://tweakers.net/x/build/components.016f7b17.js

The 016f7b17 part changes every once in a while, so you need a selector like this: 'components.*.js', but if you do that, the adblock-detection is gone, but so is the post moderation and post score.

Inside that script is the adblocker detection code, so you need to block scriptlets or replace some vars. Unfortunately, this is where my knowledge stops.

VanHamsteren avatar Mar 25 '23 12:03 VanHamsteren

Broken again unfortunately.

TheQuickFox avatar Mar 25 '23 13:03 TheQuickFox

||tweakers.net/x/build/components.*.js$script,first-party Article is readable, but post moderation and post score are gone...

tweakers.net##+js(aeld, , handleAdblockDetect) Seems ineffective.

Well, they succeeded... Had to disable uBO on that article.

nicolaasjan avatar Mar 25 '23 14:03 nicolaasjan

test first (for breakage)

tweakers.net##+js(aeld, , /^e=>.*\(e\)$/)

or if broken

@@||tweakers.net^$shide
@@||tweakers.nl^$xhr,domain=tweakers.net

mapx- avatar Mar 25 '23 18:03 mapx-

test first (for breakage)

tweakers.net##+js(aeld, , /^e=>.*\(e\)$/)

Seems to work (didn't encounter any breakage yet). Of course you'll have to disable the latest commit (00da790): @@||tweakers.net/x/build/components.*.js$script,first-party

nicolaasjan avatar Mar 26 '23 08:03 nicolaasjan

@mapx- Fixed; chosen for the second solution because of https://github.com/uBlockOrigin/uAssets/issues/17294. Reopened this issue; every issue with Tweakers can now posted here in stead of opening new issues again and again.

Nomes77 avatar Mar 27 '23 09:03 Nomes77

I noticed that this rule was added: ||tweakers.net/x/build/components.*.js$script,first-party

If you comment out that rule, the site works again. This rule removes the adblock checker, but also removes the moderation options

VanHamsteren avatar Mar 27 '23 15:03 VanHamsteren

@VanHamsteren This rule is already deleted. The problem is fixed in another way. See: https://github.com/EasyDutch-uBO/EasyDutch/commit/e04e658cd2a901056585da85d625a2169c339e8c

Nomes77 avatar Mar 27 '23 15:03 Nomes77

Again, https://tweakers.net/ detection issue. See: https://tweakers.net/reviews/9892/all/zoekmachines-en-je-privacy-googelen-zonder-alles-prijs-te-geven.html

SnowballV avatar May 08 '23 18:05 SnowballV

@SnowballV it should be fixed in https://github.com/EasyDutch-uBO/EasyDutch/commit/da679f804520d9987a3cc0a76cf4dd3eff2142b4. Try updating the list.

Nomes77 avatar May 08 '23 18:05 Nomes77

Purged and updated (twice), and refreshed the page, but on mentioned page, the issue is still there.

SnowballV avatar May 08 '23 18:05 SnowballV

@SnowballV Most likely uBO used one of our CDN's to update. For those CDN's you have always to wait at least a day before the changes are applied.

Nomes77 avatar May 08 '23 18:05 Nomes77

Ah, OK, thanks very much. I'll test again, tomorrow.

SnowballV avatar May 08 '23 18:05 SnowballV

@SnowballV I have updated two of the three CDN's (third CDN's can't be updated manually), so if you try in 30 minutes again you have now 75% chance that it will work.

Nomes77 avatar May 08 '23 18:05 Nomes77

OK, thanks, I'll try in half an hour.

SnowballV avatar May 08 '23 18:05 SnowballV

Still the same. I'll test again, tomorrow.

SnowballV avatar May 08 '23 19:05 SnowballV

@JohnyP36 told me that my changes were not working, tomorrow it should (I changed a rule, https://github.com/EasyDutch-uBO/EasyDutch/commit/ee715f05fc4ef244a7df3af18134e25c0bc94c6b).

Nomes77 avatar May 08 '23 19:05 Nomes77

Thank you very much. I purged and updated again, and now the issue is resolved. https://tweakers.net/reviews/9892/all/zoekmachines-en-je-privacy-googelen-zonder-alles-prijs-te-geven.html Thanks again.

SnowballV avatar May 08 '23 20:05 SnowballV

I have fix ee715f0 received here, but still have the detection issue, even with uBO standard configuration. uBlock Origin 1.49.3b8 Firefox 112.0.2

screenshot1

[Edit] Solved. uMatrix was still blocking aa.tweakers.nl and ab.tweakers.nl.

nicolaasjan avatar May 09 '23 04:05 nicolaasjan

I had to refresh the page a couple of times, the anti-adblock is gone now. Thanks for the fix.

Chrovax avatar May 09 '23 08:05 Chrovax

Reopened this issue; every issue with Tweakers can now posted here in stead of opening new issues again and again.

Nomes77 avatar May 31 '23 06:05 Nomes77

Due to a new adblock message on only the homepage, I have broaden the last added rule. I could find anything broken, if you find something, please report. afbeelding

P.S. anti-adblock script can be found in https://tweakers.net/x/build/frontpage.5e29f9d5.js

Nomes77 avatar Jul 26 '23 06:07 Nomes77

Sorry, for disturbing you. My issue labeler didn't do what it should have done.

Nomes77 avatar Dec 30 '23 06:12 Nomes77

Script for anti-adblock is now https://tweakers.net/x/build/frontpage.50f1df5c.js

Nomes77 avatar Jan 10 '24 11:01 Nomes77

Blocking of https://tweakers.net/x/styles/components/cookiebar/cookie_bar.fd6f85fcf49475b8103620f801820c56.css breaks the (cookie pref) model boxes:

Monosnap Gathering of Tweakers 2024-02-23 11-50-44 Monosnap Tweakers - Jouw thuis voor tech 2024-02-23 11-50-21 Monosnap Tweakers - Jouw thuis voor tech 2024-02-23 11-49-42

easylist dutch, ublock lite.

hp197 avatar Feb 23 '24 12:02 hp197