EasyCorp
Upgrade internal icons to FontAwesome 7
Upgrade internal icons to FontAwesome 7
Note: Created as draft for now because it looks like there is an issue with the new icons, some of them are cropped: https://github.com/FortAwesome/Font-Awesome/issues/20831
In the related issue that you opened in FontAwesome, they replied that this is intended and we must use overflow to let the new icons grow beyond the original size. Not sure how it's going to look in the UI 😐
Yeah, that's a weird decision. But they also suggested to use the full SVG version.
Full SVG are all the same size (square images) with margin on sides: https://github.com/FortAwesome/Font-Awesome/blob/7.x/svgs-full/solid/lock.svg https://github.com/FortAwesome/Font-Awesome/blob/7.x/svgs-full/solid/arrow-up.svg
Should we try to use full size instead? They may look a bit smaller, but the good point is that all icons will have the exact same size.
Should we try to use full size instead?
Yes, I think that makes sense. We can make some CSS tweaks if neede to fix some size issues. If this is too much work, don't worry: just update the icons and I'll take the time to fix the CSS issues. Thanks!