EasyAdminBundle icon indicating copy to clipboard operation
EasyAdminBundle copied to clipboard

Published 20 hours ago • verified publisher icon EasyCorp

Fix empty query term conditions

Open guillaume-sainthillier opened this issue 10 months ago • 6 comments

When only numeric fields are searchable, EntityRepository::addSearchClause generates a bugged DQL when search contains only non numeric terms.

guillaume-sainthillier avatar Mar 25 '24 11:03 guillaume-sainthillier

@javiereguiluz This PR is the correct fix for https://github.com/EasyCorp/EasyAdminBundle/issues/6223

https://github.com/EasyCorp/EasyAdminBundle/pull/6242 must be reverted (it breaks postgres) and replaced by this PR. See details in https://github.com/EasyCorp/EasyAdminBundle/pull/6262

Seb33300 avatar Apr 17 '24 03:04 Seb33300

@guillaume-sainthillier could you commit revert of https://github.com/EasyCorp/EasyAdminBundle/pull/6242 in this PR?

Seb33300 avatar Apr 18 '24 04:04 Seb33300

@guillaume-sainthillier could you commit revert of #6242 in this PR?

done

guillaume-sainthillier avatar Apr 18 '24 06:04 guillaume-sainthillier

Hello @Seb33300, any updates about this PR? Does I need to add something?

guillaume-sainthillier avatar May 31 '24 09:05 guillaume-sainthillier

Hi @guillaume-sainthillier, I just tried to help by reviewing it but I am not a maintainer of the project. We need to wait for @javiereguiluz to review and merge the PR.

Seb33300 avatar May 31 '24 10:05 Seb33300

Hello @javiereguiluz, any news about this PR? Does I need to add something to get this PR merged?

phpstan error is not related to PR changes

guillaume-sainthillier avatar Jun 26 '24 09:06 guillaume-sainthillier