EasyAdminBundle icon indicating copy to clipboard operation
EasyAdminBundle copied to clipboard

Use filters on nested properties

Open Marcachips opened this issue 3 years ago • 25 comments

This PR makes filters support properties with dot notation by using a new filter as wrapper.

  • The NestedConfigurator is able to configure the wrapped filter by (re)invoking the configurators collection and copy configured FormType and options to display the correct wrapped filter view.

  • The NestedFilter is able to apply required left joins for a given path and delegate query customization to wrapped filter by recreating adapted arguments (like FilterDataDto and EntityDto)

There is no tests for now, but i can add it if you are interested by the purpose.

Marcachips avatar Dec 09 '21 10:12 Marcachips

Closes #4881

Marcachips avatar Dec 09 '21 10:12 Marcachips

Thanks @Marcachips for this PR 👍

npotier avatar Dec 21 '21 08:12 npotier

This PR is really interesting and can be very useful. Is there any plan to merge it ? Does it need some adjustment or help ?

DylanKas avatar Feb 10 '22 11:02 DylanKas

Hi,

Any news about this feature?.. We still cannot use filters on embedded properties... Please review priorities, I think this is a primary feature, more than light/dark mode or others front enhancements... Many PR's about it for months and nothing. :(

Ang3 avatar Apr 20 '22 10:04 Ang3

Hey there, currently facing an issue this PR would fix, merging would be really great.

Is there anything I/we can do to help?

quentint avatar Sep 20 '22 12:09 quentint

Is there any reason this PR is still not merged ? It would be great to have the possibility to filter on nested properties !

25matt12 avatar Dec 19 '22 18:12 25matt12

I think the most important thing here are missing tests - I doubt @javiereguiluz will merge it without them.

kiler129 avatar Jan 06 '23 21:01 kiler129

same here, would be nice if it will be merged.

tonyellow avatar Jan 14 '23 11:01 tonyellow

@Marcachips will you add tests or do you need help?

msphn avatar Jan 17 '23 10:01 msphn

I plan to write tests before the end of this week. I don't need help for now, but thanks 👍

Marcachips avatar Jan 18 '23 08:01 Marcachips

@kiler129 i know but this one doesnt work wost nested entities, like product.category

tonyellow avatar Jan 21 '23 20:01 tonyellow

Tests are pushed !

Marcachips avatar Jan 23 '23 09:01 Marcachips

Hello, your PR looks very nice, what are the "blocked point" now?

Snowbaha avatar Feb 28 '23 15:02 Snowbaha

Hello, this PR will be very helpful

mathis-ait avatar Feb 28 '23 15:02 mathis-ait

Any news about this PR?

astronati avatar Jul 21 '23 22:07 astronati

@Marcachips @javiereguiluz Any news for this great feature ? I need this feature in my current project :) Thanks

fdiedler avatar Aug 06 '23 11:08 fdiedler

Hello @javiereguiluz ! Can we get visibility into the progress of this Pull Request ? Do I need to take any additional actions ?

Marcachips avatar Aug 16 '23 08:08 Marcachips

Ping of this great feature @javiereguiluz @Marcachips Hope it will be merged soon :)

wehostadm avatar Sep 18 '23 09:09 wehostadm

Ping ?

Quentin-Sch avatar Oct 16 '23 09:10 Quentin-Sch

i would also like to have it fixed to get my filter working as intended ♥

Sa-Lat avatar Oct 18 '23 13:10 Sa-Lat

Hi, up ?

MrJuliuss avatar Dec 18 '23 15:12 MrJuliuss

@javiereguiluz Some news about this PR ? Thanks

BrunoJunior avatar Feb 28 '24 14:02 BrunoJunior

I would also welcome this feature.

d3pendent avatar Mar 19 '24 10:03 d3pendent