Daniel Miller comments

Results 21 comments of


                                            Daniel Miller

Added a Grey trait, and implementations on baked-in colors. Fixes #13206

I forgot about this for a few days, but now it's here!

Add a `Gray` color trait

This came up when drafting the PR, but is the goal with this interface to have a specific input value (say `grey(0.5)`), to mean the same color in every color...

lib: Supporting building for `wasm32-wasip1`

Oh something went wrong, all the files in the project got modified. I think they got mangled newline wise (my dev setup is a bit strange)

lib: Supporting building for `wasm32-wasip1`

> Thanks. I suppose it would make sense to add this build to CI. Do you want to follow up with that? Step added, it should verify `lib` builds for...

lib: Supporting building for `wasm32-wasip1`

This should probably wait until https://github.com/martinvonz/jj/pull/4478 goes through, I feel that change is likely a higher precedence and it'd be easy to rebuild these changes.

lib: Supporting building for `wasm32-wasip1`

> Can you please adjust the commit message to `lib: Supporting building for wasm32-wasip1`, see https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews. And I'd like to know the motivation behind supporting it, if there are any....