clientcommands icon indicating copy to clipboard operation
clientcommands copied to clipboard

Published 20 hours ago • verified publisher icon Earthcomputer

/cfinditem breaks after finding the right item

Open FlameUser706 opened this issue 1 year ago • 8 comments

Every time I run /cfinditem, I always crash with a 255 error. I looked at my logs (cause prism launcher is amazing), and found the exact error I get that crashes my game. In this instance, I used /cfinditem dirt, and got this

https://pastebin.com/2vuvEXwT

Minecraft then gives a detailed error, which is below

https://pastebin.com/nMucg23W

If anybody has any idea of what any of that means, please let me know, and please give any suggestions into fixing it. Thank y'all!

FlameUser706 avatar Apr 21 '23 18:04 FlameUser706

Hi, I've looked at this a little bit, and I think that Inventory Profiles Next is making an incorrect assumption about a screen handler staying open, although I didn't quite get to the bottom of it so I don't know for sure. However I will make a bug report on that mod in case its author can provide any insights.

Earthcomputer avatar Apr 21 '23 23:04 Earthcomputer

Hi,

So far I've tested with 1.19.3 and .4 on fabric and 1.19.3 on quilt, all single player and server, and I'm unable to reproduce the crash.

blackd avatar Apr 22 '23 02:04 blackd

client-commands.webm

blackd avatar Apr 23 '23 10:04 blackd

For context, this is a paper server, and I recreated it

https://user-images.githubusercontent.com/88477166/234154640-e097db46-e284-4955-988e-580ae117bb6a.mp4

FlameUser706 avatar Apr 25 '23 02:04 FlameUser706

I would also like to note, I am running on a mac book, so that might be the reason for the crash...

FlameUser706 avatar Apr 25 '23 02:04 FlameUser706

@FlameUser706 maybe we should switch to my tracker

in the meantime can you update IPN and LIBIPN to the latest versions for 1.19.3 and test again. also if it's possible test only with IPN and client commands.

Also since I don't have a Mac it will be nice if you can help with the testing.

blackd avatar Apr 25 '23 04:04 blackd

@blackd Yeah, we can swap over

FlameUser706 avatar Apr 25 '23 23:04 FlameUser706

the description is misleading the proper steps to recreate the problems are

  1. have several chests around the player, could be empty too
  2. start /cfinditem the item we search for is relevant
  3. before the search finishes press E to open the player inventory (probably will work with any other GUI)

expected result:

the player inventory opens

real result without IPN present:

  1. the search hangs
  2. one of the containers GUI opens
  3. after random interval of time it closes
  4. search continues.

with IPN present the game crashes due to a small interval of time where the PlayerEntity.currentScreenHandler doesn't return the handler of the opened screen.
I've already implemented a "fix/workaround". But @Earthcomputer may be you should not allow the player to open GUIs while there is a ongoing search?

blackd avatar Apr 26 '23 15:04 blackd