clientcommands icon indicating copy to clipboard operation
clientcommands copied to clipboard

Crash with fabric botania installed due to @Redirect

Open BenCat07 opened this issue 4 years ago • 0 comments

Code in question is line 39 in MixinPlayerEntity.java, the redirect disallows other mods from interacting with the function, which can cause crashes if a mod (like botania) uses it.

[08:25:13] [main/FATAL]: Mixin apply failed botania.mixins.json:MixinPlayerEntity -> net.minecraft.class_1657: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @ModifyArg method net/minecraft/class_1657::onDamageTarget targets a method with an invalid signature (Lnet/minecraft/class_1297;Lnet/minecraft/class_1282;F), expected (Lnet/minecraft/class_1282;F) [INJECT Applicator Phase -> botania.mixins.json:MixinPlayerEntity -> Apply Injections ->  -> Inject -> botania.mixins.json:MixinPlayerEntity->@ModifyArg::onDamageTarget(Lnet/minecraft/class_1282;F)Lnet/minecraft/class_1282;]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @ModifyArg method net/minecraft/class_1657::onDamageTarget targets a method with an invalid signature (Lnet/minecraft/class_1297;Lnet/minecraft/class_1282;F), expected (Lnet/minecraft/class_1282;F) [INJECT Applicator Phase -> botania.mixins.json:MixinPlayerEntity -> Apply Injections ->  -> Inject -> botania.mixins.json:MixinPlayerEntity->@ModifyArg::onDamageTarget(Lnet/minecraft/class_1282;F)Lnet/minecraft/class_1282;]

BenCat07 avatar Feb 17 '21 11:02 BenCat07