aad_oauth icon indicating copy to clipboard operation
aad_oauth copied to clipboard

Add config parameter to hide signup button

Open TesteurManiak opened this issue 1 year ago • 2 comments

To give some context, my company is publishing a mobile app intended for professionals, where users are supposed to get registered through a separate process. Once registered they will be able to connect using their microsoft accounts.

The thing is that the Google Play Store has been rejecting updates to our app because we provide no way of creating an account through the app and they've been refusing our appeals demand because the Microsoft authentication portal displays an account creation button ("No account? Create one!").

For our app to be accepted we would need to be able to specify a config parameter to be able to hide this button, for example:

AadOAuth(
  Config(
    hideSignup: true, // Would default to false.
    // ...
  ),
);

If you think such feature would be relevant to be added to the package, I've got a simple implementation which you can check here: https://github.com/TesteurManiak/aad_oauth/blob/feat/hide-signup-button/lib/request_code.dart#L131-L152

I'd be glad to submit a PR if you're interested.

TesteurManiak avatar Aug 22 '24 12:08 TesteurManiak

They rejected an app I developed for a company for the same reason, so I responded like this.

I would like to clarify that the app developed is a SaaS (Software as a Service) solution, distributed to a variety of clients. Publishing it in an enterprise app store would not be viable, as the app is intended for different users and is installed directly on each client’s personal devices. This approach better serves the purpose and nature of the product.

rajada1 avatar Oct 07 '24 15:10 rajada1

They rejected an app I developed for a company for the same reason, so I responded like this.

I would like to clarify that the app developed is a SaaS (Software as a Service) solution, distributed to a variety of clients. Publishing it in an enterprise app store would not be viable, as the app is intended for different users and is installed directly on each client’s personal devices. This approach better serves the purpose and nature of the product.

This is something that we've tried to explain already, but our appeal still got rejected. It's definitely an issue with Google's reviewer and not the package in itself.

TesteurManiak avatar Oct 07 '24 15:10 TesteurManiak

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you still think this issue is needed, reopen it again.

github-actions[bot] avatar Dec 07 '24 02:12 github-actions[bot]

Closing this issue due to lack of activity.

github-actions[bot] avatar Jan 08 '25 02:01 github-actions[bot]