ThatOrThis icon indicating copy to clipboard operation
ThatOrThis copied to clipboard

feat(deps): support for 1.18.2

Open SettingDust opened this issue 3 years ago • 9 comments

Context: Stuck at https://github.com/FabricMC/fabric-loader/issues/682

SettingDust avatar Jun 15 '22 14:06 SettingDust

@EZForever After test. It works in 1.18.2 prod with fabric loader 0.14.21 CC. @Norbiros

SettingDust avatar Jul 07 '23 00:07 SettingDust

Need explain https://github.com/EZForever/ThatOrThis/issues/28

SettingDust avatar Jul 07 '23 00:07 SettingDust

@SettingDust

Wow. Did you mean it's working outside of the dev environment? I can't believe it's still possible. I'll review and try your code later when I got some spare time.

#28 is answered.

EZForever avatar Jul 07 '23 03:07 EZForever

@SettingDust

Wow. Did you mean it's working outside of the dev environment? I can't believe it's still possible. I'll review and try your code later when I got some spare time.

#28 is answered.

  • I using the ModInjector directly and it's works. - The #28 for. I can't ensure if it will causing issue
  • I using reflect to construct ModScan and compute.
  • I change the ModCandidateFinder to ClasspathModCandidateFinder that is public and shouldn't have side effect that is override It's simple and works. I can't believe why can I haven't noticed the method in the past XD

SettingDust avatar Jul 07 '23 03:07 SettingDust

Amazing, though I have to try it myself and see why on earth is that possible.

btw, I've noticed that Modsmod is still updating. What's their approach on the issues we're facing here?

EZForever avatar Jul 07 '23 03:07 EZForever

They needn't find mods. Just generate it.

SettingDust avatar Jul 07 '23 04:07 SettingDust

Good job!

Norbiros avatar Jul 07 '23 17:07 Norbiros

BTW, I gonna to refactor with yacl and support quilt for 1.19.2.

SettingDust avatar Jul 08 '23 01:07 SettingDust

BTW, I gonna to refactor with yacl and support quilt for 1.19.2.

Finally, start a new project for that https://github.com/SettingDust/ModSets

SettingDust avatar Jul 13 '23 05:07 SettingDust