etcommon-rs icon indicating copy to clipboard operation
etcommon-rs copied to clipboard

Inconsistent naming for etcommon-bigint

Open pyskell opened this issue 7 years ago • 1 comments

To use etcommon-bigint you need to specify it as etcommon-bigint in your Cargo.toml but as bigint in your main.rs.

Example: Cargo.toml:

[dependencies]
etcommon-bigint = "0.2.9"

main.rs:

extern crate bigint;

I believe this mismatch is due to the following in https://github.com/ETCDEVTeam/etcommon-rs/blob/master/bigint/Cargo.toml#L11:

[lib]
name = "bigint"

I realize changing this now would break dependencies but it is a bit confusing when trying to work with the library so maybe adding a note to the docs would be helpful? If so I can submit a PR next week.

pyskell avatar Mar 16 '18 20:03 pyskell

That would be great @pyskell, thanks :)

whilei avatar Mar 21 '18 14:03 whilei