mizuRoute icon indicating copy to clipboard operation
mizuRoute copied to clipboard

Update testlist for derecho and fix a few problems

Open ekluzek opened this issue 9 months ago • 2 comments

Update the testlist to work on Derecho, and fix some miscellaneous problems.

Fixes #520 Fixes #465 Fixes #417 Fixes #516 Fixes #519 Fixes #512 << still do

ekluzek avatar Mar 19 '25 19:03 ekluzek

Hi @ekluzek, thanks for finishing derecho test case and fixing the rpointer file I/O (which looks good to me). I will look over the rest, and merge it (unless I have any question).

There is a label WIP[do not merge]. is this supposed to be removed now?

nmizukami avatar Mar 19 '25 21:03 nmizukami

Let me run the full test list first. And there is still one more task to do on this PR.

Then I'll remove the WIP label and have you merge it. I also want to have us make a tag with it as soon as we run the test list.

ekluzek avatar Mar 19 '25 22:03 ekluzek

Hi Erik (@ekluzek), I am wondering if we can merge fixes of F90s (RtmFileUtils.F90, RtmMod.F90, rof_comp_nuopc.F90, io_rpointfile.f90, write_restart_pio.f90, write_simoutput_pio.f90) in this PR somehow? Right now, if the people clone CTSM and try to build it, they get build error. They need to incorporate these fixes manually. Let me know what you think!

nmizukami avatar Oct 20 '25 14:10 nmizukami

I haven't been able to get to this in some time. But, we should bring this in pretty much as is. With the one suggested review change.

ekluzek avatar Oct 22 '25 21:10 ekluzek