LAI streams file no longer working with FATES-SP mode

[katyarjay]

Brief summary of bug

I'm running single-point FATES-sp simulations at TOOL using an LAI streams file that I created for the site, but after updating to ctsm5.3.056 it no longer works

General bug information

CTSM version you are using: ctsm5.3.056

Does this bug cause significantly incorrect results in the model's science? Yes

Configurations affected:

Details of bug

I haven't had any issues running with this file in previous ctsm tags, but after updating to ctsm5.3.056 it no longer works. I can still run the case without errors, but GPP is 0, suggesting that the file isn't being read in correctly.

Important details of your setup / configuration so we can reproduce the bug

case configuration: Compset longname is 2000_DATM%1PT_CLM60%FATES-SP_SICE_SOCN_SROF_SGLC_SWAV_SESP

namelist changes:

use_excess_ice = .true.
snicar_snobc_intmix = .false.

flanduse_timeseries = ' '   ! This isn't needed for a non transient case, but will be once we start using transient compsets
fsurdat = "/glade/derecho/scratch/jayka/sp_test_cases_clm5.2/surfdata_1x1_NEON_TOOL_hist_2000_16pfts_c240912_organics_pft12_HTOP0.3.nc"

stream_fldfilename_lai='/glade/derecho/scratch/jayka/sp_test_cases_clm5.2/TOOL/LAI_stream_TOOL_scaled_2017-2022.nc'
model_year_align_lai=1991
stream_year_first_lai=2018
stream_year_last_lai=2021
stream_meshfile_lai='none'

z0param_method = 'ZengWang2007'

use_lai_streams = .true.
lai_mapalgo = 'nn'

! h1 output stream
hist_fincl2 = 'QSOIL', 'HTOP', 'FATES_VEGC', 'FATES_FRACTION', 'FATES_GPP', 'FATES_LAI', 'FATES_AUTORESP', 'FATES_HET_RESP', 'FATES_NPP', 'QVEGE', 'QVEGT', 'EFLX_LH_TOT', 'H2OSOI', 'FSH', 'FSR', 'FSDS', 'FSA', 'FIRE', 'FLDS', 'FCTR', 'FCEV', 'FGEV', 'BTRANMN', 'FGR', 'SOILWATER_10CM','TWS', 'QRUNOFF', 'SNOWDP', 'H2OSNO', 'FSNO', 'TV', 'TG', 'TSA', 'RAIN', 'SNOW', 'SNOW_DEPTH', 'TBOT', 'TSOI', 'ALT', 'ALTMAX', 'ATM_TOPO', 'FIRA'

hist_mfilt(2) = 600000
hist_nhtfrq(2) = 1

use_fates_daylength_factor=.true.
fates_stomatal_model='medlyn2011'
fates_leafresp_model='atkin2017'
fates_radiation_model='twostream'

@samsrabin @adrifoster

[samsrabin]

@adrifoster I had Katya tag you on this because we suspect it might have happened as part of ctsm5.3.039 (#2952). However, she was unable to test that hypothesis because her setup runs into a balance error on both that tag and ctsm5.3.038. Before we get too far down the testing rabbit hole around ctsm5.3.039, do you think anything in that tag might be causing the problem here?

For now, Katya's plan is to revert to ctsm5.3.031, where she had this working before.

[samsrabin]

Oh, and this only seems to happen when the LAI stream file is used—right, @katyarjay?

[katyarjay]

Yes, that's correct @samsrabin!

[ekluzek]

This is actually expected because of the itype PR that came in recently. So this is actually expected.

In our meeting we also affirmed that FatesSp mode is frozen for answers that affect the standard setup. Fixing this will only need to be on the CTSM side, though so should be able to come in.