CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard

Need to add the release-clm5.0 branch to your fork for the docs build tests to work

Open ekluzek opened this issue 7 months ago • 6 comments

Brief summary of bug

With the new docs build updates, you need to have the release-clm5.0 branch on your fork for the github workflows to run.

General bug information

CTSM version you are using: ctsm5.3.049-32-g0181deefd

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: PR's on forks going to master

Details of bug

See:

https://github.com/ekluzek/CTSM/actions/runs/15285357762

Important details of your setup / configuration so we can reproduce the bug

What you need to do to fix this is just add the branch to your personal fork. So for me for example:

git checkout -b release-clm5.0 escomp/release-clm5.0
git push ekluzek release-clm5.0

@samsrabin

ekluzek avatar May 27 '25 21:05 ekluzek

Yes, if you care about their results on your fork. (I don't.) But if you just want them to run on your PRs here, that shouldn't be necessary.

samsrabin avatar May 27 '25 21:05 samsrabin

We could make this happen automatically by adding a "fetch upstream's release-clm5.0" step to the relevant Workflows.

samsrabin avatar May 27 '25 21:05 samsrabin

Or: We could turn off push triggers for almost everything, since we require a PR to merge to branches we care about anyway. This would also solve the problem of tests passing in the PR and then re-running upon merge.

samsrabin avatar May 29 '25 07:05 samsrabin

We should probably talk this through this morning. But I didn't try to run it on my fork it just came up in the automatic running for open PRs when I push something to a branch on my fork to an open PR.

And it came up for both my fork and Francis when I pushed to the branch on his fork. The autorun failed so I had to add a release-clm5.0 branch to his fork.

ekluzek avatar May 29 '25 13:05 ekluzek

Yeah, it'll happen whenever a triggering push occurs on any branch in a fork. I've had a couple of other people report this as a problem as well, so we'll want to prioritize this.

samsrabin avatar Jun 04 '25 14:06 samsrabin

Another option would be to check the github.repository variable for relevant jobs and only run them if it's this one.

samsrabin avatar Jun 04 '25 14:06 samsrabin