CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard

Fix #3110 (Initialization of historical using CTSM5.4 surface datasets fails)

Open olyson opened this issue 7 months ago • 2 comments

Description of changes

If a urban tall building district (TBD) type is not found in the input restart file and TBD type is required by init_interp, allow the user to specify init_interp_fill_missing_urban_with_HD = .true. in order to fill TBD in the init_interp output file with urban high density (HD), utilizing the init_interp routines.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #): Fixes #3110

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes

Does this create a need to change or add documentation? Did you do so? Yes. No.

Testing performed, if any: Nothing yet.

Definition of done:

  • [ ] Remove hardcoded indices for columns if possible
  • [x] Clarify the second _abort test name
  • [ ] Make sure unit testing continues to work
  • [ ] @ekluzek Copy test files to inputdata and rimport them
  • [ ] @ekluzek add new system test to aux_clm
  • [ ] @ekluzek Update to latest b4b-dev branch
  • [ ] @ekluzek test aux_clm on Derecho and Izumi

olyson avatar May 14 '25 19:05 olyson

In meeting. Pain points are familiarity with the unit testing and specifically the subtlety mentioned above regarding the array index to check, and the error testing for an expected error message. Need some wiki pages or dev guide instructions on this.

@olyson said he sees the value, he was able to figure out how to get it to work on his own, and would do again.

ekluzek avatar Jun 05 '25 22:06 ekluzek

Cool, this is great @olyson. I'll look at that last conversation, and see if there's anything I come up with. But, this completes your part of this, and then I'll do my parts and send it to b4b-dev. Thanks so much!

ekluzek avatar Jun 11 '25 18:06 ekluzek

Testing for aux_clm on Derecho and Izumi is done and looks good.

ekluzek avatar Jul 10 '25 13:07 ekluzek