CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard
verified publisher icon ESCOMP

Minor fixes to names and units of canopy turbulence variables

Open mpaiao opened this issue 7 months ago • 4 comments

Description of changes

I was adding a few diagnostic variables to ELM based on the CLM code (E3SM-Project/E3SM#7328), and in the process I found a few typos and a potential bug in one of the diagnostic variables.

  1. The description and the units of variable ustar were incorrect (file src/biogeophys/FrictionVelocityMod.F90).
  2. The units listed for variable 'VPD' in the call to sub-routine hist_addfld1d (file src/biogeophys/FrictionVelocityMod.F90) is Pa, however the calculation of VPD in file src/biogeophys/CanopyFluxesMod.F90 had a 0.001_r8 multiplication factor, which I think implies conversion to kPa.
  3. Replaced the "Monin-Obukhov length" occurrences in comments and output name with "Obukhov length scale", which is consistent with Bonan (2015) and the American Meteorological Society.

Specific notes

Contributors other than yourself, if any: @olyson

CTSM Issues Fixed (include github issue #): Fixes #3112 that has the proposed fixes

Are answers expected to change (and if so in what way)? This should be bit-for-bit, only metadata and code comments updated.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: will run regular testing

mpaiao avatar May 07 '25 20:05 mpaiao

This should be able to be rebased to b4b-dev. We'll discuss at our next CTSM SE on who brings it in.

ekluzek avatar May 12 '25 17:05 ekluzek

@mpaiao I don't think that I messed anything up by rebasing to b4b-dev, but pls confirm!

slevis-lmwg avatar Dec 11 '25 01:12 slevis-lmwg

@mpaiao thank you! Could you give me permission to push to your PR? You do this by:

  • clicking Settings near the top of this page, then
  • clicking Collaborators and Teams near the top left, and following instructions

@slevis-lmwg sure thing, I just added you and @ekluzek as collaborators. Let me know if you have any trouble pushing commits to the PR. Thanks for revising and catching the spelling inconsistency.

mpaiao avatar Dec 11 '25 10:12 mpaiao

Unlikely to cause failures, but I'm testing on both machines for everyone's sanity :-)

OK ./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate
OK ./run_sys_tests -s aux_clm -c ctsm5.4.001 --skip-generate --skip-git-status

slevis-lmwg avatar Dec 12 '25 05:12 slevis-lmwg