CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard

updating fates default parameter file to api 36.1

Open rgknox opened this issue 1 year ago • 1 comments

Description of changes

This set of changes simply updates the default parameter file pointer. This is a minor API change because, while no interface code has changed, the format of the new file has indeed changed.

To do:

  • [x] A new default file must be loaded to the svn server
  • [ ] ".gitmodules" must be updated with the tag (will do so when fates-side tag is created)
  • [ ] The submodule pointer of the new fates tag must be added

Specific notes

Contributors other than yourself, if any: @JessicaNeedham @XiulinGao @mpaiao @glemieux @jenniferholm

CTSM Issues Fixed (include github issue #):

Fates 1211

Are answers expected to change (and if so in what way)?

FATES answers will change. FATES test suite has been run in a special parameter configurations previous to the PR to test B4Bness on fates side PRs.

Any User Interface Changes (namelist or namelist defaults changes)? New fates parameter file default.

Does this create a need to change or add documentation? No

Testing performed, if any: (List what testing you did to show your changes worked as expected) (This can be manual testing or running of the different test suites) (Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide) (aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

TBD

NOTE: Be sure to check your coding style against the standard (https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review the list of common problems to watch out for (https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

rgknox avatar Aug 15 '24 14:08 rgknox

@ CLM meeting we discussed adding in the new arctic PFT changes to this pr too. Is this going to happen before we merge?

wwieder avatar Aug 29 '24 15:08 wwieder

FATES-side testing ran into an issue (NGEET/fates#1254) last week, but we have a work around in place via https://github.com/ESCOMP/CTSM/pull/2700/commits/f2f75351febd4a413b0788dae256443fe5734510. I'm rerunning tests today and should be able to get to the aux_clm tests as well.

glemieux avatar Oct 02 '24 16:10 glemieux

aux_clm testing on izumi and derecho are underway.

glemieux avatar Oct 04 '24 22:10 glemieux

Testing on derecho is complete. Nearly all expected tests are B4B. All the DIFFs against baseline are for the fates tests and are expected.

There was a build error for a nvhpc compiler FatesColdSatPhen test that I hadn't seen before that I was able to clear up upon manually re-building the case:

317 NVFORTRAN-F-0004-Corrupt or Old Module file solarabsorbedtype.mod (/glade/u/home/glemieux/ctsm/components/cmeps/cime_config/../cesm/driver/esm.F90: 808)
318 NVFORTRAN/x86-64 Linux 24.3-0: compilation aborted
319 gmake: *** [/glade/u/home/glemieux/scratch/ctsm-tests/tests_1004-162240de/SMS.f45_f45_mg37.I2000Clm60FatesSpRsGs.derecho_nvhpc.clm-FatesColdSatPhen.GC.1004-162240de_nvh/Depends.nvhpc:149: esm.o] Error     2

The ERS_Ly5_P128x1.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput--clm-matrixcnOn_ignore_warnings test failed because it hit the wall clock time. I'll increase the time to 2 hours and resubmit.

Location: /glade/derecho/scratch/glemieux/ctsm-tests/tests_1004-162240de/

UPDATE: the above matrixcnOn_ignore_warnings passed B4B upon resubmit.

glemieux avatar Oct 05 '24 17:10 glemieux

Regression testing on izumi is mostly complete. I'm seeing two test hit issue #2800, so I'm resubmitting those:

FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50BgcCru.izumi_nag.clm-reduceOutput RUN time=292
FAIL ERP_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrop.izumi_nag.clm-clm60cam7LndTuningModeLDust RUN time=360

I also ran into #2801. Otherwise all expected non-fates tests are B4B.

glemieux avatar Oct 05 '24 17:10 glemieux

Regression testing on izumi is mostly complete. I'm seeing two test hit issue #2800, so I'm resubmitting those:

FAIL ERI_D_Ld9_P48x1.f10_f10_mg37.I2000Clm50BgcCru.izumi_nag.clm-reduceOutput RUN time=292
FAIL ERP_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrop.izumi_nag.clm-clm60cam7LndTuningModeLDust RUN time=360

These two passed on resubmit. Testing is complete.

Location: /scratch/cluster/glemieux/ctsm-tests/tests_1004-160528iz

glemieux avatar Oct 06 '24 00:10 glemieux