CTSM icon indicating copy to clipboard operation
CTSM copied to clipboard

`seq_drydep_mod` should be replaced by `shr_drydep_mod`

Open fvitt opened this issue 2 years ago • 2 comments

The use of seq_drydep_mod in source code should be replaced by shr_drydep_mod. As of CMEPS tag cmeps0.13.70 and cpl7 tag cpl7.0.14, seq_drydep_mod.F90 is merely a wrapper to shr_drydep_mod.F90 and is subject to be removed in a future CMEPS tag when CTSM is ready.

fvitt avatar Aug 03 '22 21:08 fvitt

@fvitt does this change answers at all or are answers identical with either version?

ekluzek avatar Aug 04 '22 07:08 ekluzek

This change does not change answers

fvitt avatar Aug 04 '22 14:08 fvitt

@billsacks and @adrifoster this is the thing that gets in the way of the Ozone tag.

ekluzek avatar Sep 01 '22 21:09 ekluzek

I think there's more than just that: It looks like we also need to stop setting drydep_method in drv_flds_in, possibly replacing it with some new variable. @fvitt can you please give us some guidance on what we need in CTSM to be compatible with https://github.com/ESCOMP/CMEPS/pull/303, similar to whatever was done in https://github.com/ESCOMP/CAM/pull/602?

billsacks avatar Sep 01 '22 21:09 billsacks

@billsacks and @adrifoster this is the thing that gets in the way of the Ozone tag.

What is the "Ozone tag"?

fvitt avatar Sep 01 '22 21:09 fvitt

I think there's more than just that: It looks like we also need to stop setting drydep_method in drv_flds_in, possibly replacing it with some new variable. @fvitt can you please give us some guidance on what we need in CTSM to be compatible with ESCOMP/CMEPS#303, similar to whatever was done in ESCOMP/CAM#602?

Would it help if I prepare a PR to ESCOMP/CTSM for this?

fvitt avatar Sep 01 '22 21:09 fvitt

@fvitt that would be great if you could make a PR for this!

The "Ozone tag" by the way is some work that @adrifoster is bringing in that passes some Ozone fields from ATM to LND. There are PR's in both CMEPS and CDEPS for it. I think the CMEPS one is cmeps0.13.71 just after your CMEPS changes came in.

ekluzek avatar Sep 01 '22 21:09 ekluzek