ESCOMP
Add all-urban option to modify_fsurdat tool and remove from mksurfdata_map
We need to add the ability to the tools to modify surface datasets to handle the all-urban case where you want everything to be urban. This option was previously embedded inside of mksurfdata_map and we need to remove it from there and add it into the modify surface dataset tools.
We talked about this morning, we are going to have a more general meeting to discuss how subset_data and modify_fsurdat tools should work together. This is definitely something that's required as we need to be able to generate the urban only single point datasets.
Technically you could also add a feature to make things like: lake-only, wetland-only, or glacier only datasets. But, we haven't had a need for that capability so far.
We talked about this at the CTSM software meeting this morning, as this is needed to create new urban single point datasets. @billsacks brought up the question of if modify_fsurdat would be the way to do this, so I'll try to evaluate that. @negin513 and I are meeting to discuss more tomorrow.
@negin513 and I talked about this, we think it will make the most sense for the urban-only option to done in the context of the fsurdat_modifier tool. The setup for the weights is not hard to do, but there are also a bunch of fields that need to be modified, and for Urban the list is very long. So I'll work on that.
hen we finish it we'll evaluate again. If we create other options (like lake-only, or glacier-only) they might be best to be handled the same way. There are fewer fields that are modified for these cases (only one for lake, but a half dozen for glacier), but still several so fsurdat_modifier might still make the most sense.