CAM icon indicating copy to clipboard operation
CAM copied to clipboard

Remove unused variables from ptend structure

Open cacraigucar opened this issue 2 years ago • 1 comments

Issue Type

Code Clean-up

Issue Description

The following variables are set but never used in the ptend structure:

  • hflux_srf
  • hflux_top
  • taux_srf
  • taux_top
  • tauy_srf
  • tauy_top

A search through a very old cam tag (cam3_2_47) revealed that even back in that tag, these variables were set and never used.

@brian-eaton - Do you happen to know why these variables were set and never used, or more importantly, if there is any reason not to remove them now?

Will this change answers?

No

Will you be implementing this yourself?

Any CAM SE can do this

cacraigucar avatar May 30 '23 17:05 cacraigucar

I can see that these elements were added between cam3.0 and cam3.1. But I can't see that they were ever actually used in the conservation checks they were intended for. It seems reasonable to remove them it they're not being used.

brian-eaton avatar Jun 01 '23 15:06 brian-eaton