CAM icon indicating copy to clipboard operation
CAM copied to clipboard

Published 20 hours ago • verified publisher icon ESCOMP

Remove old TEM functionality from FV dynamical core

Open fvitt opened this issue 1 year ago • 4 comments

Issue Type

Code Clean-up

Issue Description

Remove the deprecated TEM diagnostics scheme from the finite volume dycore code. This is superseded by the TEM physics grid scheme. The *zm history field names will be adopted by the new physics TEM scheme.

Will this change answers?

No

Will you be implementing this yourself?

Yes

fvitt avatar Mar 31 '23 17:03 fvitt

Could @dan800 or @islasimpson make a statement of verification that the FV zonal mean diagnostics that we are deprecating here, can be more-or-less reproduced using the new zonal mean method? Have we ran two FV runs, one with new, one with old? I just want to be certain before we make this irreversible decision

adamrher avatar Mar 31 '23 17:03 adamrher

I agree it would be worth running old and new in an FV run and checking them. I don't know if that has been done already as I haven't really been involved in this. I expect @dan800 knows.

islasimpson avatar Mar 31 '23 18:03 islasimpson

I will hold off on this for now. However, I think the new TEM diags scheme can use the *zm history fields names. We just cannot use both the old and new TEM schemes in the same run.

We did the testing @islasimpson is suggesting when developing the new scheme.

fvitt avatar Mar 31 '23 19:03 fvitt

We did the testing @islasimpson is suggesting when developing the new scheme.

That's good enough for me. Thanks.

adamrher avatar Mar 31 '23 20:03 adamrher