Server icon indicating copy to clipboard operation
Server copied to clipboard

The rules tradeskill skillup modifiers should probably be Real instead of Int

Open wmrojer opened this issue 5 years ago • 1 comments

Seeing that the variable the rules for tradeskill skillup modifiers is read into is a float and the comment "// Remember: skillup_modifier is (float). Lower is better" in the code and the way the skillup chance is calculated the rules should probably be stored and read as RULE_REAL instead of RULE_INT. Default values are between 1 and 4 and the note says lower is better. So not many different steps to increase the chance without the rule being a float.

The affected rules are: TradeskillUpAlchemy, TradeskillUpBaking, TradeskillUpBlacksmithing, TradeskillUpBrewing, TradeskillUpFletching, TradeskillUpJewelcrafting, TradeskillUpMakePoison, TradeskillUpPottery, TradeskillUpResearch, TradeskillUpTinkering.

wmrojer avatar Mar 30 '19 20:03 wmrojer

And there isn't even a rule for Tailoring. Maybe add that one or it's hard coded to 2.0

wmrojer avatar Mar 30 '19 20:03 wmrojer

Resolved in #2674, Tailoring looks to have been added as well.

Aeadoin avatar Dec 25 '22 21:12 Aeadoin