awesome-ha-blueprints icon indicating copy to clipboard operation
awesome-ha-blueprints copied to clipboard

Fix Zigbee2MQTT command names in philips_324131092621.yaml

Open RobertClarke64 opened this issue 1 year ago • 6 comments

Command names for Hue Dimmer blueprint were using hypens for Zigbee2MQTT, where they should be underscores, like in ZHA. Fixes #541.

Proposed change

Fix the command names for Hue Dimmer switches connected using Zigbee2MQTT. The blueprint was expecting hyphens before, where it should be expecting underscores. This resulted in a broken blueprint.

Note that this change is already reflected in the blueprint for the Hue Dimmer v2 remote. I'm using the v1 remote and the commands use underscores.

Simply changes:

    zigbee2mqtt:
      button_on_short: [on-press]
      button_on_long: [on-hold]
      button_on_release: [on-hold-release]
      button_off_short: [off-press]
      button_off_long: [off-hold]
      button_off_release: [off-hold-release]
      button_up_short: [up-press]
      button_up_long: [up-hold]
      button_up_release: [up-hold-release]
      button_down_short: [down-press]
      button_down_long: [down-hold]
      button_down_release: [down-hold-release]

to this:

    zigbee2mqtt:
      button_on_short: [on_press]
      button_on_long: [on_hold]
      button_on_release: [on_hold_release]
      button_off_short: [off_press]
      button_off_long: [off_hold]
      button_off_release: [off_hold_release]
      button_up_short: [up_press]
      button_up_long: [up_hold]
      button_up_release: [up_hold_release]
      button_down_short: [down_press]
      button_down_long: [down_hold]
      button_down_release: [down_hold_release]

Checklist

  • [x] I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • [x] I properly tested proposed changes on my system and confirm that they are working as expected.
  • [x] I formatted files with Prettier using the command npm run format before submitting my Pull Request. ^ no but I only swapped some hyphens for underscores :)

RobertClarke64 avatar Apr 29 '23 17:04 RobertClarke64

Hey @RobertClarke64, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

github-actions[bot] avatar Apr 29 '23 17:04 github-actions[bot]

Thank you, your PRed version works well!

mutovkin avatar Jun 18 '23 22:06 mutovkin

I think someone should go ahead and merge this?

OBoudreaux avatar Dec 27 '23 20:12 OBoudreaux

@EPMatt Is this repository still maintained? Seems like quite a few people have benefited from this PR and it should probably be merged.

RobertClarke64 avatar Dec 30 '23 13:12 RobertClarke64

This fix doesn't quite do it yet. The events should not be

    zigbee2mqtt:
      button_on_short: [on_press]

but

    zigbee2mqtt:
      button_on_short: [on_press_release]

I'm currently preparing a PR to fix this and I will combine it with a few other fixes.

nomike avatar Feb 03 '24 03:02 nomike

I patched the blueprint in my environment and it worked! Regardless of this, I would really appreciate a fix in your GitHub repository

brdcg avatar Mar 04 '24 09:03 brdcg