awesome-ha-blueprints icon indicating copy to clipboard operation
awesome-ha-blueprints copied to clipboard

Add support for some Symfonisk controllers which have different event…

Open zapp42 opened this issue 2 years ago • 3 comments

… names.

Info about mine: Firmware: 0x21022631 Quirk: zhaquirks.ikea.symfonisk.IkeaSYMFONISK1

Fixes #423.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! :tada: Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

Proposed change*

Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put closes #XXXX in this section to auto-close relevant issues.

Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.

Make sure to provide enough information so that your pull request can be reviewed.

Checklist*

  • [x] I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • [x] I properly tested proposed changes on my system and confirm that they are working as expected.
  • [ ] I formatted files with Prettier using the command npm run format before submitting my Pull Request.

zapp42 avatar Oct 19 '22 07:10 zapp42

Hey @zapp42, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

github-actions[bot] avatar Oct 19 '22 07:10 github-actions[bot]

Can confirm that this fixes all problems with my Symfonisk, before only play/pause worked.

codeaphex avatar Nov 12 '22 14:11 codeaphex

Is anyone able to approve this PR?

berendhaan avatar Jan 31 '23 18:01 berendhaan