awesome-ha-blueprints
awesome-ha-blueprints copied to clipboard
Enhancement: Adding PhilipsHue Integration & Philips FriendsOfHue Controller
Proposed change*
This closes feature request #150 and #149
Closes #149. Closes #150.
Checklist*
- [X] I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
- [X] I properly tested proposed changes on my system and confirm that they are working as expected.
- [x] I formatted files with Prettier using the command
npm run format
before submitting my Pull Request.
Hey @krys1976, thank you so much for your contribution! 🚀
🔄 We're currently running a few checks to make sure that everything is great with your contribution. We'll update this comment with progress regarding your changes. If additional actions need to be performed before your contribution can be reviewed, additional guidance will be provided below.
Results are coming soon, stay tuned!
Hey @EPMatt, thank you so much for your contribution! 🚀
🔄 We're currently running a few checks to make sure that everything is great with your contribution. If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.
Results are coming soon, stay tuned!
Hey @EPMatt,
✅ Your contribution passed all the checks, awesome! A maintainer will soon review your submission and provide additional feedback regarding your changes.
Thanks again for dedicating your precious time to this project. 🔥
📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links.
https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/foh/foh.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/philips_324131092621/philips_324131092621.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/philips_8718699693985/philips_8718699693985.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/cover/cover.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/light/light.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/media_player/media_player.yaml
Good Morning Matteo,
first of all, we all have a life outside the web. I'm glad that you found time to review my contribution now.
- I totally agree with you, that we should follow this naming. But in this case, the Friends of Hue Controller is a collection of multiple devices, all having same behaviour. This is grounded to the implementation of pyhue. They also show up in Philips Hue App as one item, but having to choose its commercial product:
- ABB Smart Switch
- Busch-Jaeger smart light switch
- Eltako Smart Switch
- Feller Smart light control
- Jumitech Smart Switch
- JUNG Friends of Hue Switch
- Lutron Aurora
- Niko Dimmer Switch for Hue
- Nodon smart switch for hue
- OPUS Friends of Hue Switch
- Retrotouch Friends of Hue Switch
- RunLessWire Click
- Senic Friends of Hue Switch (the one I use, but it has 6 different models)
- TCS hidden socket
- Vimar Friends of Hue Switch
- Voltus eVoToggle.
- Of course we should add a page all about this. 3-5. Assistance would be appreciated
Best regards
Chris
Hey @EPMatt,
✅ Your contribution passed all the checks, awesome! A maintainer will soon review your submission and provide additional feedback regarding your changes.
Thanks again for dedicating your precious time to this project. 🔥
📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links.
https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/foh/foh.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/philips_324131092621/philips_324131092621.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/controllers/philips_8718699693985/philips_8718699693985.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/cover/cover.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/light/light.yaml https://github.com/krys1976/awesome-ha-blueprints/blob/main/blueprints/hooks/media_player/media_player.yaml
Hi @krys1976,
thank you so much for your quick reply. I've applied some code suggestions similar to the ones you applied earlier today, leaving open what's left to discuss.
- Thank you for providing the list of "Friends of Hue" devices. It's interesting that so many devices are grouped into a single item in the Hue app. However, I don't know whether different models from different manufacturers use the same mappings and events for their devices. It might be interesting to investigate this point a little bit deeper before publishing the blueprint; in my opinion, user feedback regarding at least 1-2 models in addition to the ones you're using might be great. Having such approach would help us to identify the right naming for the controller blueprint, and for the controller model selection in hooks. I'd like not to add unnecessary, duplicate blueprints for only slightly different devices. Instead, I'd prefer having one (or more, depending whether different models use all the same mappings) blueprint covering multiple devices. The list of supported controllers would then list all of the different available devices, linked to the same blueprint doc page. In my opinion the latter point is crucial, as we should avoid that users think their devices are not supported by our blueprints, just because not listed in the controllers list. What do you think of this approach? Please let me know your thoughts about it. :)
3-5. Great, I'll take care of these points regarding docs as soon as we're done with the blueprints. 👍🏻
Thanks again!
- Thank you for providing the list of "Friends of Hue" devices. It's interesting that so many devices are grouped into a single item in the Hue app. However, I don't know whether different models from different manufacturers use the same mappings and events for their devices.
As I mentioned before, these controllers have all the same behaviour. This is related to the specs of that sample device and its implementation to pyhue. As we not map directly against the hardware, there will not be an other possibility. A further investigation is not needed in my opinion.
And yes, we should list them all. We could add this a second list to that controller page, or integrate into existing, listing them all, and mark them which are verified for working etc.
Hi @krys1976,
thank you for your quick feedback.
A further investigation is not needed in my opinion.
Ok, I agree with you that no testing is needed since they're all based on pyhue (didn't pay attention to that piece of information, so I thought it was only a nice way to group all of them in the Hue App).
And yes, we should list them all. We could add this a second list to that controller page, or integrate into existing, listing them all, and mark them which are verified for working etc.
Great, I'd go for both adding them in the main list and creating a second list in the Friends of Hue Switch blueprint. 👍🏻 Marking which controllers are reported to be fully working is crucial.
Given our conclusion, I think we should call the blueprint friends_of_hue
(philips_friends_of_hue
sounds tricking to me, it might let users think that the blueprint is compatible with Philips devices only). What do you think?
Thanks again!
Great, I'd go for both adding them in the main list and creating a second list in the Friends of Hue Switch blueprint. 👍🏻 Marking which controllers are reported to be fully working is crucial.
I totally agree
Given our conclusion, I think we should call the blueprint
friends_of_hue
(philips_friends_of_hue
sounds tricking to me, it might let users think that the blueprint is compatible with Philips devices only). What do you think?
I prefer friends_of_hue or friends_of_hue_family ... Philips_* would mislead users.
Hi @EPMatt
I was busy the past weeks, so I wasn't able to put effort into it. Yesterday I noticed why my instance of home assistant had many problems with switches and lights. So i fixed a problem regarding transitions first, and tomorrow morning I will have time to finalise the things here.
Cheers, Chris
Is there any update on this Enhancement?
Hi there,
🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR.
Thanks!