user-story icon indicating copy to clipboard operation
user-story copied to clipboard

Updated the pagination

Open dikshashukla455 opened this issue 2 years ago • 1 comments

Issue Number

fixes #195

Describe the changes you've made

I had made pagination arrows disable/hidden along with their text ('prev' and 'next') when the pagination is not needed.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

N/A

Checklist

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Preview: Deploy preview link here with the appropriate route

http://localhost:3000/

dikshashukla455 avatar Mar 27 '22 20:03 dikshashukla455

Changes requested

Greetings @cyntss, the main issue is the icon visibility actually. The whole injection has already skipped the DOM altogether. There is the main span class that has the condition for hiding the 'prev' and 'next' buttons when pagination is not needed but it doesn't change the icon's color because EOS icons have their several own props which color prop is one of them. I just changed the icon visibility color which matches the text with the help of the 'color' prop when pagination is not required. It works perfectly fine in the browser. You can see this hosted link http://localhost:3000/. Kindly review it.

dikshashukla455 avatar Mar 29 '22 08:03 dikshashukla455