:construction: Rename model to routine in yaml configs
This solution works, but is surely brittle, and we should probably pin the minor version of lightning.
- [x] Pin the minor
lightningversion
Codecov Report
:x: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 98.08%. Comparing base (94af1d5) to head (a62a9b3).
:warning: Report is 3 commits behind head on dev.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| torch_uncertainty/utils/cli.py | 88.23% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #211 +/- ##
==========================================
- Coverage 98.10% 98.08% -0.02%
==========================================
Files 175 175
Lines 9165 9184 +19
Branches 1163 1164 +1
==========================================
+ Hits 8991 9008 +17
- Misses 106 107 +1
- Partials 68 69 +1
| Flag | Coverage Δ | |
|---|---|---|
| pytest | 98.08% <88.23%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We can postpone the merging if you think that other matters are more pressing.
@.**** approved this pull request.
Looks good to me @o-laurent https://github.com/o-laurent. We will have to make sure the documentation is up to date, though, when we remove the baselines.
— Reply to this email directly, view it on GitHub https://github.com/ENSTA-U2IS-AI/torch-uncertainty/pull/211#pullrequestreview-3075303049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO7X36YSHL25ZZXWBBUBJ2L3LIG2TAVCNFSM6AAAAACCZTH4WSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANZVGMYDGMBUHE . You are receiving this because you were mentioned.Message ID: @.***>
We can postpone the merging if you think that other matters are more pressing.
I think #196 takes precedence. I will work on it this week!