django-debug-toolbar-requests icon indicating copy to clipboard operation
django-debug-toolbar-requests copied to clipboard

Signature of requests.get is broken.

Open proofit404 opened this issue 7 years ago • 3 comments

We can't use

requests.get("http://api.linkpreview.net/", {"key": key, "q": url})

anymore.

proofit404 avatar Dec 01 '18 07:12 proofit404

Hi @proofit404 , could you explain it more, please? What it means that it is broken? What it doing?

rbas avatar Dec 03 '18 11:12 rbas

https://github.com/requests/requests/blob/b0ad2499c8641d29affc90f565e6628d333d2a96/requests/api.py#L63

The issue is that you can't use params as a positional argument after your monkey patches.

So code which works with requests doesn't work with your toolbar extension.

proofit404 avatar Dec 03 '18 11:12 proofit404

Oh you're right. I'll fix it. Thank you for report

rbas avatar Dec 03 '18 12:12 rbas