ecs-object-client-java icon indicating copy to clipboard operation
ecs-object-client-java copied to clipboard

JakartaEE 10 support

Open JSamir opened this issue 11 months ago • 5 comments

We are migrating our application to JakartaEE 10 and faced issues, it seems the client does not support running in JakartaEE 10 context.

Is there a plan to make it JEE10 compatible?

JSamir avatar Feb 26 '24 15:02 JSamir

Currently we have not planned targeting JakartaEE.

dunedodo avatar Apr 12 '24 05:04 dunedodo

Since we were migrating our own application and therefore are familiar with the topic, we tried patching the ecs client ourselves. In general it works for us, although someone with knowledge about the internals of the client would need to have a look at few minor issues.

Would you accept a PR?

JSamir avatar Apr 12 '24 06:04 JSamir

Yes, please. We will help review.

dunedodo avatar Apr 12 '24 06:04 dunedodo

We're currently building a release thus I will only have time for the PR in 1-2 weeks.

But one thing I wanted to mention already is that the changes we have made would make things work with JEE10, but JEE8 would not work (anymore). So you would either need to drop JEE8 support or somehow make both work.

JSamir avatar May 10 '24 05:05 JSamir

We're currently building a release thus I will only have time for the PR in 1-2 weeks.

But one thing I wanted to mention already is that the changes we have made would make things work with JEE10, but JEE8 would not work (anymore). So you would either need to drop JEE8 support or somehow make both work.

Thank you. I don't quite know how compatability work in JakartaEE 10 with Java 8 and 11, but object-client should always support Java 8 and 11. It looks like JakartaEE 9 works with Java 8 and Java 11? FYI., we are likely to have Java 17 support in the future which is TBD, not sure if this can help. It doesn't work ATM though.

dunedodo avatar Jul 03 '24 08:07 dunedodo