datapoint-python icon indicating copy to clipboard operation
datapoint-python copied to clipboard

Python 3.12, versioneer build failure

Open scop opened this issue 2 years ago • 6 comments

versioneer.py attempts to use configparser.SafeConfigParser which has been deprecated for a long time, and now removed in Python 3.12, causing build to fail.

Upgrading versioneer to a newer version would seem likely to fix this: https://github.com/python-versioneer/python-versioneer/issues/200

scop avatar Jan 07 '23 14:01 scop

Is this library still maintained and open for PRs?

Ryanmt2 avatar Feb 07 '24 21:02 Ryanmt2

It appears the repository is likely not being maintained. If I am understanding correctly then the fix appears it may be as simple as changing these lines in versioneer.py:

342 parser = configparser.SafeConfigParser() to parser = configparser.ConfigParser()

344 parser.readfp(f) to parser.read_file(f)

I think people would be happy to contribute to its maintenance if able.

DustyArmstrong avatar Feb 08 '24 19:02 DustyArmstrong

Hi, I haven't been able to do much with the repo.o er the last few years. I'll take a look at the pull request that updates versioneer this weekend.

Perseudonymous avatar Feb 08 '24 20:02 Perseudonymous

Thanks, appreciate it and your efforts to create the project. I use Datapoint every day (Home Assistant integration) so would be thrilled to keep using it if possible. I am a fair weather coder so can't say for sure but I hope the PR resolves.

DustyArmstrong avatar Feb 08 '24 20:02 DustyArmstrong

This should be fixed in version 0.9.9 - I could install it from pypi in a python 3.12 environment on my machine.

I bumped the entire versioneer package, but ended up disabling it. The packaging logic here is really out of date now, so I'll see if I can get it into a better state if it looks like this library will be usable with the new API

Perseudonymous avatar Feb 09 '24 21:02 Perseudonymous

Mention the HA pull as we cant comment on it due to being locked to collaborators :-(. This should allow this to be reintegrated into HA. https://github.com/home-assistant/core/pull/108163

        Yup, sadly not a lot I can do for MetOffice at the moment if the datapoint library isn't going to be compatible 😭

Originally posted by @MrHarcombe in https://github.com/home-assistant/core/issues/108163#issuecomment-1896273727

And a link to HA issue https://github.com/home-assistant/core/issues/109301

and re-enabled by https://github.com/home-assistant/core/pull/110206 maybe in HA 2024.2.2 Thanks @DustyArmstrong

pssc avatar Feb 17 '24 17:02 pssc