datapoint-python icon indicating copy to clipboard operation
datapoint-python copied to clipboard

Status of maintenance

Open jacobtomlinson opened this issue 5 years ago • 16 comments

I created this project a few years ago to simplify accessing the Met Office Datapoint API for my projects. I was working in IT Support at the Met Office at the time and specifically wanted it to automate some vanity features like changing wallpaper automatically based on the weather. Despite being employed at the Met Office this is an unofficial and unsupported way of accessing the APIs, hence why it lives under my personal github namespace.

Around 4 years ago I moved to the @informatics-lab in the Met Office and my maintenance on this project decreased with time as I was not actively using it in my day to day activities.

Recently @EJEP picked up maintenance of the project and has been extremely helpful. I've only weighed in from time to time with some project direction.

I've recently left the Met Office and therefore my interest in this project has decreased even further. I know it is a dependency of other projects such as @home-assistant and so I would like to see it maintained, but I just can't justify this activity myself any longer.

Therefore I would like to discuss our options here. Would @EJEP like to take on sole ownership of the project? If so should it be transferred to your GitHub account? If not then what other options are there?

jacobtomlinson avatar Jul 08 '19 11:07 jacobtomlinson

I'm happy to take on the project. The options I see are to switch my fork to be the main repository or create an organisation for the project to live in

Perseudonymous avatar Jul 09 '19 11:07 Perseudonymous

Ok I'm officially passing the baton to you.

Happy with either of those approaches. Just let me know what you want to do and I'l transfer it. There may also be some extra work for CI and deployments which will need to be done.

jacobtomlinson avatar Jul 09 '19 14:07 jacobtomlinson

Cool, thanks for all the work creating this in the first place. I'll have a look at the benefits of the options and what needs to be done with the CI and deployments over the next couple of weeks.

Perseudonymous avatar Jul 09 '19 19:07 Perseudonymous

Thanks Jacob for creating this - using this package was my first python project and I learned a lot from reading the code. Many thanks to Emlyn for taking over - really appreciate it!

On Tue, Jul 9, 2019 at 8:39 PM Emlyn Price [email protected] wrote:

Cool, thanks for all the work creating this in the first place. I'll have a look at the benefits of the options and what needs to be done with the CI and deployments over the next couple of weeks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jacobtomlinson/datapoint-python/issues/109?email_source=notifications&email_token=AIL25QW3TQSYDSAOSYO2HQTP6TSNNA5CNFSM4H622BG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRJXKI#issuecomment-509778857, or mute the thread https://github.com/notifications/unsubscribe-auth/AIL25QVPLJWD63RP6YRNS5TP6TSNNANCNFSM4H622BGQ .

tonyjward avatar Jul 10 '19 09:07 tonyjward

@jacobtomlinson From what I have read the repository can be transferred to me, provided I delete my fork. GitHub does not allow a repository to be transferred if the recipient has a fork of the repository. I can merge the outstanding pull request and then this can be done without any problems.

I need to look at how to transfer ownership of the PyPi and Travis pages

Perseudonymous avatar Jul 26 '19 21:07 Perseudonymous

It looks like I can be added to the PyPi project and then you can remove yourself.

Perseudonymous avatar Jul 26 '19 22:07 Perseudonymous

Thanks for this. Looks like I can't remove myself, you will probably have to remove me.

image

jacobtomlinson avatar Jul 29 '19 08:07 jacobtomlinson

I see, I do have the option to remove you. I will wait until I have found out what to do about travis to do so though.

Perseudonymous avatar Jul 29 '19 20:07 Perseudonymous

From the travis page it looks like I have the ability to edit the environment variables associated with the build. As far as I can see the rest is controlled using travis.yml.

The major thing that is not clear in travis.yml is what the env: -secure variable is. Could you tell me what this is and if I need to replace it?

Perseudonymous avatar Jul 29 '19 20:07 Perseudonymous

I think it's an API key for datapoint for running the integration tests. I think it's used here.

You might want to add it in the Travis UI instead and set it to your own key, then remove that from the .travis.yml all together.

jacobtomlinson avatar Jul 30 '19 09:07 jacobtomlinson

I think the list of things to do is:

  1. Change Travis credentials (PyPi and API key) to mine
  2. Delete my fork of the repository
  3. Transfer the main repository to me

Perseudonymous avatar Aug 04 '19 21:08 Perseudonymous

Travis doesn't expose encrypted environment variables to pull requests from other branches so I had to create a new branch in this repository. This successfully used my API key to run the integration tests.

Perseudonymous avatar Sep 09 '19 20:09 Perseudonymous

Based on this I am confident that switching to my PyPi credentials will work. @jacobtomlinson I will now delete my fork. When you are ready please transfer ownership of the repository to me and I will add my credentials for releases to PyPi.

Perseudonymous avatar Sep 09 '19 20:09 Perseudonymous

Just requested the transfer

jacobtomlinson avatar Sep 10 '19 08:09 jacobtomlinson

I have replaced your credentials with my own in Travis. The only remaining step is to remove you from the PyPi and ReadTheDocs owners lists.

Perseudonymous avatar Sep 10 '19 21:09 Perseudonymous

Feel free to go ahead with this.

jacobtomlinson avatar Sep 13 '19 08:09 jacobtomlinson