OpENer icon indicating copy to clipboard operation
OpENer copied to clipboard

Published 20 hours ago • verified publisher icon EIPStackGroup

Warnings

Open jvalenzuela opened this issue 2 years ago • 3 comments

Updated pull request to master, a066b34, addressing VS and some GCC compiler warnings.

jvalenzuela avatar Mar 05 '22 20:03 jvalenzuela

Could we get this merged?

widavies avatar Jul 01 '22 21:07 widavies

I realize this is a lot of changes. I can help make it easier to merge, perhaps selecting one commit at a time to consider, then reorder or rebase it as necessary to make it a simple, FF merge into master, resulting in a linear history.

jvalenzuela avatar Jul 02 '22 01:07 jvalenzuela

I'd be willing to help review & test this if needed as well to get it merged.

widavies avatar Jul 05 '22 15:07 widavies

Hi, also here sorry for the very long delay. Yes, if we could split this in several PRs this would be easier. I already know I can not merge all, as at least one of your cleanups would again open a security leak, enabling to put OpENer into an infinite loop

MartinMelikMerkumians avatar Oct 04 '22 10:10 MartinMelikMerkumians

Ok, I'll close this pull request, rebase as needed, and open new pull requests for each.

jvalenzuela avatar Oct 04 '22 12:10 jvalenzuela