logseq-copilot
logseq-copilot copied to clipboard
group block results from same page into single list item
Hi @EINDEX,
I have made some changes to group all the block results from same page into one single div in the search page. Please below screenshot for reference.
Although I think the message passing between background process and content script is not updated. I'm not sure how exactly to change that.
Please have a look and merge it if it looks good
Hi @AnweshGangula
I love this change, will making some time to review the code.
I just have one question about the sorting logic for grouped result.
Cause currently we are using same ordering as the logseq searching result.
- In my opinion the sorting within a group doesn't really matter (from a user perspective) - because as a user I'm interested to know if I have something related to the google search query in my notes, not really the timeline of those notes
- But I'm wondering if its better to sort the group's themselves - displaying the group with max blocks at the top, so most relevant page is displayed at the top
Hi @AnweshGangula
I found some cases, where the style of grouped items is not as perfect as the searching page.
-
In the popup, I think the total width in the popup is too narrow.
I have some suggestions to enhance this:
- Remove the text
to blockand change it to a hover prompt. After all, users do not need to see the textto blockevery time. - Increase the width of the popup so that it reaches 400px.
- It seems that there is a bit too much left padding for each small item in the popup.
- Remove the text
-
The task item's style is strange in the popup and search page.
- in popup
- in the search page
Maybe you are not using task items in logseq, cloud you also consider task items in grouped results.
- in popup
Would you like to improve this? I realize that your frontend and UX skills are better than mine.
- But I'm wondering if its better to sort the group's themselves - displaying the group with max blocks at the top, so most relevant page is displayed at the top
I agree with your point, I do not care about the sorting, but I really want the most relevant result shows on the top.
I had manually merged your code. Thanks @AnweshGangula