ldacBT icon indicating copy to clipboard operation
ldacBT copied to clipboard

Allow build with CMake 4.0.0

Open heitbaum opened this issue 8 months ago • 2 comments

use min...max syntax to allow build with newer cmake.

ref: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

heitbaum avatar Apr 14 '25 14:04 heitbaum

Why don't you just raise the minimum version to at least 3.5 or 3.10?

a17r avatar May 01 '25 19:05 a17r

Why don't you just raise the minimum version to at least 3.5 or 3.10?

If that is the preference - we can (thus dropping support for building with < 3.10) - no issue either way, as the CMakeLists.txt file does not have use any functionality 3.0-3.10.

Ideally best to go with a minimum, as then there is no need to support the range.

generally there has been a 50/50 direction set with packages I raised PRs on, some went range (they wanted to continue to support old cmake, the others when with 3.10 or greater)

heitbaum avatar May 01 '25 19:05 heitbaum