rayhunter icon indicating copy to clipboard operation
rayhunter copied to clipboard

[Feature Request]: Move telcom parser to it's own crate

Open cooperq opened this issue 7 months ago • 6 comments

What problem does this feature solve or what does it enhance?

Currently telcom parser is in rayhunter which bloats the code and the compile time. It should be it's own crate.

Proposed Solution

Move telecom parser to it's own separate crate and project.

Alternatives Considered

Keep telcom parser in the code and have looooong compile times and an artificially huge codebase.

cooperq avatar Jun 06 '25 17:06 cooperq

I don't think you'll get any improvements in compile time. maybe we should incorporate https://github.com/swatinem/rust-cache for that

untitaker avatar Jun 06 '25 18:06 untitaker

I think the only way to get shorter compile times for telcom parser would be to break it up into smaller subcrates -- moving it into its own project doesn't mean we'll avoid compiling it.

Caching builds in CI is definitely an option.

I looked at this a few weeks ago and because it mostly generates code it wasn't trivial to break it into subcrates. The goal of subcrates is to allow parallel compilation of orthogonal parts of the crate, as each crate is compiled single-threaded.

oopsbagel avatar Jun 06 '25 18:06 oopsbagel

that makes sense, it should probably still be ti's own crate though

cooperq avatar Jun 06 '25 19:06 cooperq

separate repo still?

oopsbagel avatar Jun 07 '25 20:06 oopsbagel

Moving it out of the cargo workspace (to its own repo) will make running clippy way faster.

gaykitty avatar Jun 08 '25 00:06 gaykitty

yes it should be a separate repo

cooperq avatar Jun 16 '25 18:06 cooperq