privacybadger
privacybadger copied to clipboard
Leaves a lot of blank space
This might not be the right place for this report, sorry if not.
Using http://www.citymetric.com/transport/tfl-has-unveiled-london-s-new-night-tube-map-and-it-beautiful-1161 as an example:
With Adblock Plus:
With Privacy Badger:
This is the right place! Clearly we have some work to do on the code which collapses hidden divs.
Is that this method? Replacing the noop
with a method that runs console.log or alert when it runs doesn't reveal that that method is ever called. Is there a different method that collapses empty divs, or something else I'm missing?
Actually it was a built in adblock plus method which is no longer there. This would need to be written from scratch.
Also see #907 and #1754 for Chrome and Opera versions of the unsightly browser message shown when Privacy Badger blocks an embedded document frame.
See https://github.com/EFForg/privacybadger/pull/1766#issue-272288074 for links to collapsing approaches taken by other content blocking extensions.