privacybadger icon indicating copy to clipboard operation
privacybadger copied to clipboard

Leaves a lot of blank space

Open John-Colvin opened this issue 9 years ago • 5 comments

This might not be the right place for this report, sorry if not.

Using http://www.citymetric.com/transport/tfl-has-unveiled-london-s-new-night-tube-map-and-it-beautiful-1161 as an example:

With Adblock Plus: screenshot 2015-06-24 12 43 01

With Privacy Badger: screen shot 2015-06-24 at 12 52 37

John-Colvin avatar Jun 24 '15 11:06 John-Colvin

This is the right place! Clearly we have some work to do on the code which collapses hidden divs.

cooperq avatar Jun 24 '15 19:06 cooperq

Is that this method? Replacing the noop with a method that runs console.log or alert when it runs doesn't reveal that that method is ever called. Is there a different method that collapses empty divs, or something else I'm missing?

tmcw avatar Dec 16 '16 21:12 tmcw

Actually it was a built in adblock plus method which is no longer there. This would need to be written from scratch.

cooperq avatar Jan 05 '17 02:01 cooperq

Also see #907 and #1754 for Chrome and Opera versions of the unsightly browser message shown when Privacy Badger blocks an embedded document frame.

ghostwords avatar Nov 07 '17 16:11 ghostwords

See https://github.com/EFForg/privacybadger/pull/1766#issue-272288074 for links to collapsing approaches taken by other content blocking extensions.

ghostwords avatar Nov 15 '17 19:11 ghostwords