EFForg
fix: change tab order on tracking domains page
This fixes #3107
I used PR #3122 as a starting point, and made sure the tests pass and the UI was not affected (too badly). Used flexbox on the tracking domain rows so that tabbing works implicitly with the HTML elements.
Attempted to knock out #3103 also since they are related, but I wasn't able to find a quick, clean way to make the toggle-switch direction-agnostic so I'll leave that for another day.
Hello and thank you for the PR!
I have a few initial observations below. Let me know if anything is unclear.
- When navigating through UI elements using Tab, the new spacer element on each row is present in navigation order. If the spacer elements are truly necessary, they should at least not be focuseable via mouse or keyboard.
- The legend/key icons in the header above the slider toggle buttons are not aligned with the slider toggles.
- The slider toggle buttons are not aligned with each other. They should be aligned in the same vertical column as they are now. This may be because the domains no longer get cut off with ellipses past a certain width.
- The legend icons in the header are on the wrong side of the screen in RTL mode.
- Moving a domain toggle in RTL mode makes the toggles change position on the screen.
Also, when keyboard navigating on the options page, the focus outlines around the "x" and the domain names are larger/longer than they should be.
Thanks for the feedback, I will work on cleaning those things up. I think for the alignment issues I will see if using CSS grid instead of flexbox helps, it should be easier to keep things in structured columns. Shouldn't be much trouble.
The RTL mode things also make sense.
I updated the PR.
I thought about it some more and I don't think fixing this requires adding any flex layout stuff. Really the main thing is swapping the order we define the html elements in and that would resolve the tab order. Which eliminates all of the changes which affected the alignment of the toggles.
I did adjust the css for the "undo" icon a bit, because I noticed that the "remove" icon wraps whenever the "undo" icon is displayed.
Also I moved the DNT icon to the right of the fqdn because it is focusable element and the tab flow of focusing on the fqdn, then going left to the DNT icon, then right again to the toggle seemed awkward. I am wondering if that even stood out to you as a problem to begin with, but also I want to make sure it's ok to move the icon. If it needs to stay on the left I can put it back and either leave the tabbing behavior as-is or adjust it a different way.
Finally, for the RTL support I can work on all of that as part of #3103. This updated PR at least preserves the existing functionality in that regard.