privacybadger icon indicating copy to clipboard operation
privacybadger copied to clipboard

Published 20 hours ago • verified publisher icon EFForg

Use `Navigator.prototype` for DNT & GPC signal injectors

Open eligrey opened this issue 2 years ago • 4 comments

This fixes #2788. This is currently untested until I try out your build process.

eligrey avatar Jul 24 '21 03:07 eligrey

Sorry I haven't had the time to update this PR until now. @ghostwords mind giving it another review?

eligrey avatar Sep 18 '21 05:09 eligrey

@ghostwords I updated this PR to address your feedback. Note my response regarding the usage of Navigator instead of navigator.

eligrey avatar Sep 23 '21 23:09 eligrey

I'm not exactly sure how disconnect.me tries to inject this property.

It should be an easy fix for the DuckDuckGo extension, so I'll also submit a corresponding PR for them. It looks like it's as simple as doing the same change I did here and in OptMeOwt: https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/develop/shared/js/content-scope/gpc-protection.js

I'd say merge it 👍

eligrey avatar Sep 25 '21 05:09 eligrey

You could open an issue with Disconnect (perhaps on https://github.com/disconnectme/disconnect) asking them where the latest code lives.

ghostwords avatar Sep 27 '21 13:09 ghostwords

hey @ghostwords can we merge this pr?

michaelfarrell76 avatar Jun 22 '23 19:06 michaelfarrell76

Disconnect's implementation still has a number of issues:

  • Does not set on Navigator.prototype
  • Defaults to false
  • Overwrites other extensions' navigator signal

ghostwords avatar Jul 25 '23 16:07 ghostwords